[WWSTCERT-13550] Sonoff - Add the pressure display function to SNZB-02M by laity-w-sudo · Pull Request #3194 · SmartThingsCommunity/SmartThingsEdgeDrivers

laity-w-sudo · 2026-08-25T08:45:58Z

Check all that apply

Type of Change

WWST Certification Request
- If this is your first time contributing code:
  - I have reviewed the README.md file
  - I have reviewed the CODE_OF_CONDUCT.md file
  - I have signed the CLA
- I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
Bug fix
New feature
Refactor

Checklist

I have performed a self-review of my code
I have commented my code in hard-to-understand areas
I have verified my changes by testing with a device or have communicated a plan for testing
I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Adding the air pressure function to the SNZB-02M equipment

Summary of Completed Tests

github-actions · 2026-08-25T08:46:28Z

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions · 2026-08-25T08:46:29Z

Profile category check: ✅ Passed - all profiles have a category defined.

github-actions · 2026-08-25T08:47:06Z

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/qyMZQQwZPjmY

github-actions · 2026-08-25T08:48:03Z

Test Results

73 files ±0 542 suites +1 0s ⏱️ ±0s
3 267 tests +2 2 822 ✅ - 443 0 💤 ±0 0 ❌ ±0 445 🔥 +445
5 256 runs +2 4 667 ✅ - 587 0 💤 ±0 0 ❌ ±0 589 🔥 +589

For more details on these errors, see this check.

Results for commit 1cd32e1. ± Comparison against base commit 71bbd3d.

♻️ This comment has been updated with latest results.

github-actions · 2026-08-25T08:48:07Z

zigbee-humidity-sensor_coverage.xml

File	Coverage
All files	`98%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-humidity-sensor/src/sonoff/init.lua	`93%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-humidity-sensor/src/plant-link/init.lua	`96%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-humidity-sensor/src/frient-sensor/air-quality/init.lua	`98%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-humidity-sensor/src/lazy_load_subdriver.lua	`57%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-humidity-sensor/src/init.lua	`93%`	✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 1cd32e1

The SNZB-02M sub-driver was added but never registered, so the pressure display feature was dead code on the device. Register it via sub_drivers.lua, drop the unrelated SNZB-02LD/WD handler and utils (not in this driver, and referencing a nonexistent sub-driver), and add unit tests for pressure conversion and refresh. Co-Authored-By: Claude <noreply@anthropic.com>

cjswedes

My biggest concern is the lack of configuration for reporting the PressureMeasurement MeasuredValue attribute; has this been tested manually?

cjswedes · 2026-09-08T17:47:17Z

Is there a reason to have the nested directories? We should just add a sonoff subdriver rather than having sonoff/SNZB-02M. We want to avoid having single subdrivers for each model.

Please change the directory structure so that it is not nested, and everything falls under the sonoff directory.

cjswedes · 2026-09-08T17:53:46Z

+  zigbee_handlers = {
+    attr = {
+      [clusters.PressureMeasurement.ID] = {
+        [clusters.PressureMeasurement.attributes.MeasuredValue.ID] = pressure_report_handler


Did you test that the PressureMeasurement attribute is reported automatically when the value changes? I do not see any reporting configuration for the attribute or binding of the cluster. I would expect to see a call in a device_init handler to device:add_configured_attribute to ensure this configuration is setup when the device is configured.

Most clusters get configured due to default functionality, but I dont believe we are configuring this one with the defaults, so the subdriver should be doing so.

@laity-w-sudo
here is the example of cluster configuration in the subdriver:

SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-power-meter/src/frient/EMIZB-151/init.lua

Line 98 in 71bbd3d

local device_init = function(self, device)

Add the pressure display function to SNZB-02M

1f3d8bb

laity-w-sudo force-pushed the main branch 2 times, most recently from ae161d5 to b5e3665 Compare August 25, 2026 11:23

laity-w-sudo added 3 commits August 25, 2026 20:20

Fix SNZB-02M lazy-load and pressure test

46e746d

Load-SNZB-02M-handlers-during-lazy-load

0909220

Limit-parallel-driver-tests-to-changed-drivers

1ca26b1

KKlimczukS reviewed Aug 31, 2026

View reviewed changes

KKlimczukS requested a review from cbaumler August 31, 2026 09:20

KKlimczukS changed the title ~~Add the pressure display function to SNZB-02M~~ [WWSTCERT-13550] Sonoff - Add the pressure display function to SNZB-02M Aug 31, 2026

cbaumler requested review from aleclorimer and cjswedes August 31, 2026 14:35

cjswedes requested changes Aug 31, 2026

View reviewed changes

Comment thread tools/run_driver_tests_p.py

KKlimczukS requested changes Sep 1, 2026

View reviewed changes

Comment thread drivers/SmartThings/zigbee-humidity-sensor/profiles/sonoff-humidity-temp-press-battery.yml Outdated

laity-w-sudo requested a review from KKlimczukS September 3, 2026 03:25

laity-w-sudo added 2 commits September 3, 2026 11:36

Merge branch 'SmartThingsCommunity:main' into main

7780cd9

Modify the relevant contents of SNZB-02M according to the suggestions

b7123f5

KKlimczukS reviewed Sep 3, 2026

View reviewed changes

Comment thread drivers/SmartThings/zigbee-humidity-sensor/src/test/test_sonoff_snzb02m.lua Outdated

Comment thread drivers/SmartThings/zigbee-humidity-sensor/src/sub_drivers.lua Outdated

laity-w-sudo requested review from KKlimczukS and cjswedes September 4, 2026 02:18

Modify the relevant contents of SNZB-02M according to the suggestions

494c68c

cjswedes reviewed Sep 8, 2026

View reviewed changes

laity-w-sudo added 3 commits September 9, 2026 10:14

Merge branch 'SmartThingsCommunity:main' into main

080b525

Modify the relevant contents of SNZB-02M according to the suggestions

8285d2e

Modify the relevant contents of SNZB-02M according to the suggestions

f303440

Modify the relevant contents of SNZB-02M according to the suggestions

1cd32e1

KKlimczukS requested a review from cjswedes September 10, 2026 11:54

Uh oh!

Conversation

laity-w-sudo commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Checklist

Description of Change

Summary of Completed Tests

Uh oh!

github-actions Bot commented Aug 25, 2026

Uh oh!

github-actions Bot commented Aug 25, 2026

Uh oh!

github-actions Bot commented Aug 25, 2026

Uh oh!

github-actions Bot commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

github-actions Bot commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cjswedes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cjswedes Sep 8, 2026

Choose a reason for hiding this comment

Uh oh!

cjswedes Sep 9, 2026

Choose a reason for hiding this comment

Uh oh!

cjswedes Sep 8, 2026

Choose a reason for hiding this comment

Uh oh!

cjswedes Sep 9, 2026

Choose a reason for hiding this comment

Uh oh!

KKlimczukS Sep 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

laity-w-sudo commented Aug 25, 2026 •

edited

Loading

github-actions Bot commented Aug 25, 2026 •

edited

Loading

github-actions Bot commented Aug 25, 2026 •

edited

Loading