update - #431
Open
itsmylife44 wants to merge 3098 commits into
Open
Conversation
Contributor
|
It is the biggest pull request in one hit that I have ever seen in Github. 🙈 To the moon 🚀. |
|
These changes will work on latest snipa pool if I add them? what is best way to implement them? it will work for Aeon still? I am worried about DB changes |
Contributor
|
It works with Aeon, of course. Aeon is a sibling of Monero, much simpler than other coins. |
MoneroOcean
force-pushed
the
master
branch
2 times, most recently
from
August 11, 2018 07:49
c8f6dd3 to
3f45f35
Compare
MoneroOcean
force-pushed
the
master
branch
2 times, most recently
from
January 10, 2019 18:32
8aa7251 to
054f3e1
Compare
… (safe-additive audit fixes)
The workerMax check pre-incremented (++count <= workerMax), so an over-limit login that is rejected still bumped the count; that worker never connects, so it is never decremented and the count drifts up over time until legitimate miners under the real limit are wrongly rejected. Check before incrementing (intent of refactor ef46e97 was only to bound worker count). Suite green.
…unt leak, long_runner key-0 resume, template one-shot - manage_scripts/exchange_recovery_cache_common.js: key buildBlockLookup by the LMDB `_key` the callback yields, not the non-existent block.id (was always NaN -> lookup 100% broken). - lib/pool/miner_registry.js: check proxy worker count before incrementing so a rejected over-limit login doesn't leak the count (twin of the protocol.js 302d649 fix). - lib/long_runner.js: compare goToRange() !== false in the reverse-resume branch so an LMDB key value of 0 isn't mis-treated as "not found" (mirrors the forward branch). - lib/pool/templates.js: make the header-fetch-error reschedule one-shot (requireTrue) like the success path, so a bootstrap (undefined repeating) call can't spawn a second poll loop. - factories.js + protocol.js: fix 'extranoces' -> 'extranonces' miner-facing typo (+ test). Suite green (504 pass).
…r guard/import, collapse duplicate coinHashFactor branches (behavior-preserving, eslint+tests green)
…(skip cycle, not crash) createBlockTemplate (RtmBlockTemplate/RavenBlockTemplate) runs inside the daemon-RPC reply callback, which jsonRequest invokes OUTSIDE its try/catch — so any template-build throw (malformed bits/version/ previousblockhash, too-many/unparseable txs) propagated uncaught and could crash the process. Wrap the build in try/catch and, on failure, log + return like a no-result reply so the pool skips that template cycle and retries next poll. Suite 504/504.
Recognize the current lin, mac, and win release names while retaining compatibility with legacy platform suffixes. Cover platform selection and Linux compatibility-build preference in the live helper tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.