Repository navigation
refactor(dlx): drop the force option and range detection - #1630
Merged
Oskar Haarklou Veileborg (BarrensZeppelin) merged 1 commit intoOct 19, 2026
Conversation
Oskar Haarklou Veileborg (BarrensZeppelin)
added this pull request to stack #1631
October 19, 2026 09:27
Oskar Haarklou Veileborg (BarrensZeppelin)
requested a review
from Martin Torp (mtorp)
October 19, 2026 09:39
Oskar Haarklou Veileborg (BarrensZeppelin)
marked this pull request as ready for review
October 19, 2026 09:39
Martin Torp (mtorp)
approved these changes
Oct 19, 2026
Oskar Haarklou Veileborg (BarrensZeppelin)
force-pushed
the
oskar/rea-875-dlx-cleanup
branch
from
October 19, 2026 09:42
bafbd8e to
d72b1fe
Compare
Coana was the only caller of spawnDlx that passed `force: true`, and the only one with a version range. cdxgen and synp are pinned and launched with `silent: true`, so neither code path runs any more.
Oskar Haarklou Veileborg (BarrensZeppelin)
force-pushed
the
oskar/rea-875-dlx-cleanup
branch
from
October 19, 2026 09:43
d72b1fe to
459903f
Compare
Oskar Haarklou Veileborg (BarrensZeppelin)
merged commit Oct 19, 2026
b1f2ffc
into
v1.x
16 checks passed
Oskar Haarklou Veileborg (BarrensZeppelin)
deleted the
oskar/rea-875-dlx-cleanup
branch
October 19, 2026 09:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coana was the only caller of spawnDlx that passed
force: true, and theonly one with a version range. cdxgen and synp are pinned and launched
with
silent: true, so neither code path runs any more.Part of REA-875.
Expected reviewer effort: Stamp
Stack created with GitHub Stacks CLI • Give Feedback 💬
Note
Low Risk
Internal DLX helper cleanup with no remaining
forcecallers; pinned cdxgen/synp paths unchanged aside from removed dead options.Overview
Simplifies
spawnDlxby removing cache-bypass and version-range behavior that only Coana needed.DlxOptionsno longer includesforce.spawnDlxno longer detects semver ranges to auto-enable force or defaultsilentto true for unpinned versions—silentnow defaults tofalseunless callers opt in (cdxgen/synp helpers still passsilent: true). For pnpm, thenpm_config_dlx_cache_max_ageenv override is gone;npm_config_ignore_pnpmfileremains. For npm/npx,--forceis no longer added. Tests drop coverage for force, cache bypass, and unpinned silent defaults.Reviewed by Cursor Bugbot for commit bafbd8e. Configure here.