chore(lint): satisfy no-shop-metaphor-jargon across main - #226
Closed
John-David Dalton (jdalton) wants to merge 2 commits into
Closed
chore(lint): satisfy no-shop-metaphor-jargon across main#226John-David Dalton (jdalton) wants to merge 2 commits into
John-David Dalton (jdalton) wants to merge 2 commits into
Conversation
Contextual rewrites at all 44 sites: 'seam' becomes 'injection point' where the comment means a DI/test injection (spawn injection point, test injection path, injectable launch point) and 'boundary' where it means a plain architecture boundary (factory boundary, streaming boundary, node:http boundary); 'wedged' becomes 'unresponsive'; the plural 'seams' naming pure helper modules becomes 'helpers'. Comment-only — no behavior changes. The git temp-repo suites are flaky on this machine (extended-real-ops 'temporary git repository' fails intermittently on pristine main too); every other suite passes, and the socket lint error count is 0.
ERR_PNPM_LOCKFILE_CONFIG_MISMATCH: the lockfile's catalogs block drifted from pnpm-workspace.yaml's catalog config (broken on main — every recent CI run fails the frozen install in setup-and-install). Regenerated with pnpm install --no-frozen-lockfile; the workspace yaml and .gitignore are untouched. The catalog entries refresh within their declared ranges; pnpm install --frozen-lockfile now passes.
John-David Dalton (jdalton)
force-pushed
the
chore/jargon-sweep
branch
from
August 15, 2026 07:08
f5b97bf to
e38f83f
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Collaborator
Author
|
Closing unmerged: fleet members land changes directly to main; both commits (jargon sweep + lockfile realign) are being landed there instead of via PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
no-shop-metaphor-jargonrule landed ahead of the repo — whole-repo lint (and therefore every PR's Check gate, including #225's) failed on 44 pre-existing sites. This sweep fixes them contextually, comment-only:seam→injection pointwhere the comment means a DI/test injection (spawn injection point, test injection path, injectable launch point, test-seam)seam→boundarywhere it means a plain architecture boundary (factory boundary, streaming boundary, node:http boundary, describe boundaries)seams(plural, naming pure helper modules) →helperswedged→unresponsive(3 sites)Verification: socket lint error count 0, whole-repo pre-push lint green. Unit tests: the git temp-repo suites are flaky on this machine —
extended-real-ops's 'temporary git repository' fails intermittently on pristine main too (1 failure both with and without this change); all other suites pass.