Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
remove message twice prompt: append messagesection once in issue.js
…ession shapes" This reverts commit c788c05.
fix(dev): use authn compatibility login flow
…@3.1.3-5) (latest: rdflib@2.3.9)
…e-pane into solidosDependencies
Solidos dependencies
reverse to inherit secrets
…@5.0.0-0) (latest: rdflib@2.4.0)
Staging version
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the build/output to a new lib/ bundle, factors shared webpack module rules, and introduces CSS-based styling plus improved error handling (including accessible modal dialogs) across the issue pane UI.
Changes:
- Consolidate webpack module rules into
webpack.module.rules.mjsand update dev/prod webpack configs to use them, producing normal + minified UMD bundles inlib/. - Replace many inline styles / console usage with CSS classes and centralized
debuglogging + reusable error UI (errors.js) and modal dialogs (localUtils.js). - Update packaging/CI for a staging workflow and prerelease publishing setup (new version, new
main, staging branch CI,lib/ignore, etc.).
Reviewed changes
Copilot reviewed 25 out of 29 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| webpack.module.rules.mjs | New shared webpack module.rules (JS/TS, CSS, TTL). |
| webpack.dev.config.mjs | Switch dev webpack config to shared moduleRules. |
| webpack.config.mjs | New production builds (normal + minified) into lib/, copy CSS, add terser/min build. |
| src/newTracker.js | Move button styling to CSS, add alert dialog + debug logging. |
| src/newTracker.css | Add class-based styling for the new tracker button. |
| src/newIssue.js | Add alert dialog + CSS-based layout, add close button and cancel hook. |
| src/newIssue.css | Styles for the new issue form/title input. |
| src/localUtils.js | New accessible modal dialog helper with focus trap and overlay management. |
| src/localUtils.css | Styles for modal overlay/dialog + buttons. |
| src/issuePane.js | Integrate error section, CSS imports, and improved error/log handling across flows. |
| src/issuePane.css | Add issue pane styles for buttons and error section layout. |
| src/issue.js | Refactor overlay visibility to CSS classes; integrate modal + error section + CSS classes. |
| src/issue.css | Add styling for overlay, issue cards, issue panel, and message area. |
| src/errors.js | New reusable error-section renderer (renderErrorSection) and complain helper. |
| src/errors.css | Ensure hidden error sections are actually not displayed (override mashlib CSS). |
| src/debug.js | Centralize console logging behind log/warn/error/trace. |
| src/csvButton.js | Improve CSV copy flow with dialogs and error handling. |
| src/csvButton.css | CSS file for CSV button styling (imported by issue pane). |
| src/board.js | Replace inline styles with CSS classes and import board.css. |
| src/board.css | Add board/table/card styling via classes. |
| README.md | Add dev setup section + note about generative AI annotations. |
| package.json | Switch outputs to lib/, update version/deps, mark CSS as side effects, add engines. |
| eslint.config.mjs | Ignore lib/**. |
| dev/index.js | Make login banner updates more defensive and update login detection logic. |
| dev/dev-global.css | Add extensive local-dev global CSS/variables and accessibility styles. |
| declarations.d.ts | Add TypeScript module declaration for importing .ttl as string. |
| .gitignore | Ignore lib/ build output. |
| .github/workflows/ci.yml | Add staging branch triggers and add upstream dependency update job + permissions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+60
to
+66
| function hideSiblings (hide, dom) { | ||
| const siblings = Array.from(dom.body.children).filter(c => c !== modalOverlay) | ||
| siblings.forEach(el => { | ||
| if (hide) el.setAttribute('aria-hidden', 'true') | ||
| else el.removeAttribute('aria-hidden') | ||
| }) | ||
| } |
Comment on lines
+115
to
+117
| widgets.button(context.dom, icons.iconBase + 'noun_1180156.svg', 'close', hideOverlay)) | ||
| button.classList.add('trackerOverlayCloseButton') | ||
| delete button.style.backgroundColor // do not want white |
Comment on lines
+40
to
+44
| const focusable = Array.from(modalOverlay.querySelectorAll('button, [href], input, select, textarea, [tabindex]:not([tabindex="-1"])')).filter(el => !el.hasAttribute('disabled')) | ||
| if (focusable.length === 0) return | ||
| const idx = focusable.indexOf(dom.activeElement) | ||
| if (e.shiftKey) { | ||
| if (idx === 0) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.