Repository navigation
fix: deduplicate concurrent Solid document loads - #349
Open
SharonStrats wants to merge 1 commit into
Open
SharonStrats wants to merge 1 commit into
SharonStrats wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Pending loads can cross identity transitions and expose a previous identity’s response, while recursive batch loading can incorrectly join requests that should remain excluded.
2 open issues
What changed in this PR
This PR adds in-flight document-load sharing to SolidLogic, aiming to reduce duplicate startup requests, including loads rdflib internally forces after authentication transitions.
Changes:
- Adds a document-keyed pending-request map with cleanup after success or failure.
- Installs the sharing wrapper when creating the store’s fetcher.
- Adds tests for concurrent sharing, retries, settled requests, and excluded load modes.
| File | Description |
|---|---|
test/shareConcurrentLoads.test.ts |
Adds coverage for sharing, cleanup, retries, and exclusions. |
src/util/shareConcurrentLoads.ts |
Implements the concurrent-load sharing wrapper. |
src/logic/solidLogic.ts |
Integrates the wrapper into store initialization. |
Review effort: Balanced
Prompt: Share simultaneous plain document loads in solid-logic so startup callers reuse one in-flight request, including loads that rdflib upgrades internally after an authentication transition. Do not share forced, option-bearing, or batch loads, and clear entries when requests settle so explicit refreshes and retries retain their existing behavior. Add regression coverage for concurrent sharing, failed-load retries, and excluded load modes. Co-authored-by: GPT-5.6 Luna <gpt-5.6-luna@openai.com>
timea-solid
reviewed
Oct 30, 2026
timea-solid
left a comment
timea-solid
left a comment
Member
There was a problem hiding this comment.
complicated matter. I wonder if it is needed at this level. Can we test without this first?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prompt: Share simultaneous plain document loads in solid-logic so startup callers reuse one in-flight request, including loads that rdflib upgrades internally after an authentication transition.
Do not share forced, option-bearing, or batch loads, and clear entries when requests settle so explicit refreshes and retries retain their existing behavior. Add regression coverage for concurrent sharing, failed-load retries, and excluded load modes.