Skip to content

Fix manage access click #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SharonStrats merged 7 commits into from
Aug 27, 2026
Merged

Fix manage access click #753

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
165688b
change the method name in manager
SharonStrats Aug 26, 2026
b453bad
chore: update solidos dependencies (dev: solid-logic@6.0.0-0 solid-ui…
github-actions[bot] Aug 26, 2026
6065e21
fix horizontal scroll problem
SharonStrats Aug 26, 2026
b31934f
minor dev pane styling
SharonStrats Aug 27, 2026
d5dc2eb
change icon and better styling
SharonStrats Aug 27, 2026
e7556d8
Merge pull request #755 from SolidOS/change-share-icon
SharonStrats Aug 27, 2026
82606cf
Merge pull request #754 from SolidOS/fix-styling
SharonStrats Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
140 changes: 70 additions & 70 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 8 additions & 3 deletions src/components/file-explorer-header/FileExplorerHeaderControls.styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@
flex: 0 1 auto;
}

.file-explorer-header-action-button {
width: var(--solid-ui-clickable-area, 42px);
height: var(--solid-ui-clickable-area, 42px);
padding: 0;
}

/* TODO: look into what colors to use this is just to show */
.dirtyIndicator {
display: inline-flex;
Expand All @@ -31,7 +37,7 @@
white-space: nowrap;
}

icon-lucide-share-2,
icon-lucide-user-round-cog,
icon-lucide-pencil {
width: 16px;
height: 16px;
Expand All @@ -49,8 +55,7 @@
gap: 5px;
}

.file-explorer-header-access-button,
.file-explorer-header-edit-button {
.file-explorer-header-action-button {
display: none;
}

Expand Down
8 changes: 4 additions & 4 deletions src/components/file-explorer-header/FileExplorerHeaderControls.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { customElement, property, state } from 'lit/decorators.js'
import { consume } from '@lit/context'
import { html, nothing } from 'lit'
import 'solid-ui/components/button'
import '~icons/lucide/share-2'
import '~icons/lucide/user-round-cog'
import '~icons/lucide/pencil'
import styles from './FileExplorerHeaderControls.styles.css'
import '../resource-actions-menu/ResourceActionsMenu'
Expand Down Expand Up @@ -82,11 +82,11 @@ export default class FileExplorerHeaderControls extends WebComponent {
${this.renderDirtyIndicator()}
${!isContainerResource && !this.isMobile
? html`
<solid-ui-button class="file-explorer-header-access-button" variant="ghost" title="Manage Access" @click=${this.fileExplorerContext.handleAccessClick}>
<icon-lucide-share-2 slot="icon"></icon-lucide-share-2>
<solid-ui-button class="file-explorer-header-action-button" variant="ghost" title="Manage Access" @click=${this.fileExplorerContext.handleAccessClick}>
<icon-lucide-user-round-cog slot="icon"></icon-lucide-user-round-cog>
</solid-ui-button>
<solid-ui-button
class="file-explorer-header-edit-button"
class="file-explorer-header-action-button"
variant="ghost"
title=${this.getEditTooltip()}
?disabled=${!this.fileExplorerContext.paneSupportsEditing || !this.canEdit}
Expand Down
6 changes: 6 additions & 0 deletions src/components/resource-actions-menu/ResourceActionsMenu.styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
:host {
.file-explorer-header-more-button {
width: var(--solid-ui-clickable-area, 42px);
height: var(--solid-ui-clickable-area, 42px);
padding: 0;
}

.ellipsisIcon {
width: 16px;
height: 16px;
Expand Down
8 changes: 4 additions & 4 deletions src/components/resource-actions-menu/ResourceActionsMenu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import 'solid-ui/components/button'
import 'solid-ui/components/menu'
import 'solid-ui/components/menu-item'
import '~icons/lucide/ellipsis-vertical'
import '~icons/lucide/share-2'
import '~icons/lucide/user-round-cog'
import '~icons/lucide/pencil'
import { LiveStore } from 'rdflib'
import styles from './ResourceActionsMenu.styles.css'
Expand Down Expand Up @@ -44,7 +44,7 @@ export default class ResourceActionsMenu extends WebComponent {
const canManageAccess = !!this.handleAccessClick
return html`
<solid-ui-menu>
<solid-ui-button slot="trigger" variant="ghost" title="More options">
<solid-ui-button slot="trigger" class="file-explorer-header-more-button" variant="ghost" title="More options">
<icon-lucide-ellipsis-vertical slot="icon" class="ellipsisIcon"></icon-lucide-ellipsis-vertical>
</solid-ui-button>
${this.menuItems.map(item => html`
Expand All @@ -64,15 +64,15 @@ export default class ResourceActionsMenu extends WebComponent {
${!isContainerResource && this.isMobile && canManageAccess
? html`
<solid-ui-menu-item @solid-ui-select=${this.handleAccessClick}>
<icon-lucide-share-2 slot="left-icon"></icon-lucide-share-2>
<icon-lucide-user-round-cog slot="left-icon"></icon-lucide-user-round-cog>
Manage Access
</solid-ui-menu-item>
`
: nothing}
${isContainerResource && canManageAccess
? html`
<solid-ui-menu-item @solid-ui-select=${this.handleAccessClick}>
<icon-lucide-share-2 slot="left-icon"></icon-lucide-share-2>
<icon-lucide-user-round-cog slot="left-icon"></icon-lucide-user-round-cog>
Manage Access
</solid-ui-menu-item>
`
Expand Down
6 changes: 1 addition & 5 deletions src/dataContentPane.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,8 @@
}

div.data-content-pane {
border-top: solid 1px var(--color-data-pane-border-top, black);
border-left: solid 1px var(--color-data-pane-border-top, black);
border-bottom: solid 1px var(--color-data-pane-border-side, #777);
border-right: solid 1px var(--color-data-pane-border-side, #777);
border: 1px solid var(--solid-ui-color-gray-200, #cbd5e1);
padding: var(--spacing-base, 0.5rem);
margin-top: var(--spacing-base, 0.5rem);
margin-bottom: var(--spacing-base, 0.5rem);
}

Expand Down
Loading
Loading