[gregaubert]

The font setup example currently uses separate CSS @import requests. Update it to load Inter and Ubuntu Mono through one stylesheet link in the HTML head, with preconnects and display=swap, following SonarSource/sonarcloud-webapp#8229.

Clarify application ownership of font loading, page-specific font requests, Echoes fallback stacks, and self-hosted font variants. Documentation only; no runtime or public API changes.

[netlify]

✅ Deploy Preview for echoes-react ready!

Name	Link
🔨 Latest commit	207625f
🔍 Latest deploy log	https://app.netlify.com/projects/echoes-react/deploys/6ad9d3c25e6b3d77b6697848
😎 Deploy Preview	https://deploy-preview-808--echoes-react.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[hashicorp-vault-sonar-prod]

ECHOES-1495

[gitar-bot]

Code Review ✅ Approved 2 closed / 2 findings

🟢 Low risk · README.md updates font-loading guidance only; executable behavior and public interfaces remain unchanged.

Updates the font-loading guidelines to use a single stylesheet link with preconnects and display=swap for Inter and Ubuntu Mono, and clarifies app ownership of font loading, page-specific requests, fallback stacks, and self-hosted variants. Approved with suggestions: two minor open findings flag that the Sonar font guidance in README.md will conflict with the bundled Geist fonts in #798 and #801 if merged without adjusting the wording.

✅ 2 closed

Closed: Cross-PR: Sonar font guidance turns wrong once #798 bundles Geist

📄 README.md:62-76
Breaks when #798 merges (before or after this PR) and the README conflict in the Fonts section is resolved by keeping this PR's text.

How

1. README.md:62 says Sonar uses Inter and Ubuntu Mono and that importing the brand CSS does not load the fonts.
2. README.md:64-71 tells every Sonar-brand entry point to add a Google Fonts link for Inter and Ubuntu Mono.
3. ECHOES-1446 Implement Brand A design language #798 changes the Sonar brand to Geist/Geist Mono, bundled via @font-face in design-tokens/assets/sonar.css, and rewrites the same README hunk to say so, dropping the Google Fonts/self-hosting example.
4. If this PR's wording survives the merge, Sonar consumers are told to fetch fonts the brand no longer uses. That adds a third-party request, and the note that Sonar bundles its fonts (OFL license) is lost.

Fix

• This PR: If ECHOES-1446 Implement Brand A design language #798 lands first, rebase and limit the "application loads the fonts" guidance and the Inter/Ubuntu Mono example to brands that don't bundle fonts (e.g. Gitar).
• ECHOES-1446 Implement Brand A design language #798: When resolving the README conflict, keep the bundled-Geist description for Sonar and keep this PR's <link>/preconnect guidance only for brands that still need app-loaded fonts.

Compared 207625f with #798 at 5a8b51c

Closed: Cross-PR: 'App must load fonts' claim contradicts #801's bundled sonar-new

📄 README.md:62
Breaks when #801 merges with this PR, and the README Fonts conflict is resolved in a way that keeps this PR's opening paragraph unchanged.

How

1. README.md:62 states as a general rule that the consuming application loads the fonts and that importing the brand CSS does not.
2. ECHOES-1492 SONAR-NEW Add light and dark design token palettes #801 adds sonar-new.css, which bundles Geist/Geist Mono via @font-face, and adds a README paragraph about it in the same hunk.
3. Both PRs edit the same opening lines, so a manual merge can drop ECHOES-1492 SONAR-NEW Add light and dark design token palettes #801's paragraph or keep a blanket statement that is false for sonar-new.

Fix

• This PR: Say the app-loading requirement applies to brands that don't bundle fonts (Sonar, Gitar), so a sonar-new exception fits without contradiction.
• ECHOES-1492 SONAR-NEW Add light and dark design token palettes #801: When rebasing, keep the sonar-new bundled-Geist paragraph alongside this PR's <link>-based guidance, replacing the old @import/.woff text.

Compared 207625f with #801 at b86a997

Verification Rules 2/2 met Repos 1 inspected · PRs 2 inspected

Functional validation No results

Rules 2 passed 1 not applicable

✅ Internal artifact registries
✅ Repository license compliance

Broader impact Repos 1 inspected PRs 2 inspected

Cross-repo 1 repository inspected 0 open impacts

SonarSource/sonarqube-webapp Inspected

Cross-PR 2 PRs inspected 0 open impacts

PR 801: ECHOES-1492 SONAR-NEW Add light and dark design token palettes Inspected
PR 798: ECHOES-1446 Implement Brand A design language Inspected

Auto-approval Not enabled

Set up

_{For more verification details, comment gitar display:verbose.}

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube