Repository navigation
fix: BED-10372 bound collection retries and timeouts - #95
Conversation
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
HTTP retry session and collection outcomes src/openhound_github/github_rest_client.py, src/openhound_github/source.py, tests/test_github_rest_client.py, tests/test_github_app_retry.py, tests/test_collection_continuation.py, README.md |
Adds a session with 10–30 second request timeouts and bounded retries for transient failures. The API client uses this session. Tests cover retry limits, rate limits, credential refresh, and collection behavior after exhausted retries. The README describes these settings and outcomes. |
Adaptive GraphQL page retry budget src/openhound_github/helpers.py, tests/test_graphql_retry_budget.py |
GraphQL pagination activates a shared transient-failure budget for each page. Gateway responses can trigger a smaller page size only when another candidate exists and the budget is not exhausted. Tests cover retries, fallback, and page retention. |
Workflow path and file handling src/openhound_github/resources/organization.py, tests/test_workflow_resources.py |
Workflow collection skips workflows with absent paths or paths beginning with dynamic/. Workflow-file retrieval failures are logged and return no file content, so failed workflows do not produce job or step rows. |
Priority:
Estimated code review effort: 3 (Moderate) | ~20 minutes
Change: Bug fix
Suggested reviewers: d3vzer0
Merge Risk: 
6c084
-
The change bounds transient retries and skips failed workflow-file retrievals. No concrete merge-blocking issue was established.
Pre-merge checks: 
-
Check name Status Explanation Resolution Docstring Coverage Docstring coverage is 11.11% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta… Write docstrings for the functions missing them to satisfy the coverage threshold. -
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main changes: limiting collection retries and request timeouts. The issue identifier adds useful context without obscuring the change. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 11.11% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 27 functions across 9 files. (1 skipped: 1 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit checks each page with care,
Three quick tries, then smaller there.
The missing paths are left behind,
While later records still unwind.
The workflow files that fail to load
Leave no child rows along the road.
Comment @coderabbitai help to get the list of available commands.
Transient GitHub server and network failures can leave collection silent for many minutes while requests retry. This change uses 10-second connection and 30-second read timeouts and caps transient failures at three attempts. Adaptive GraphQL pagination shares that budget across page sizes instead of restarting HTTP retries at each size.
Exhausted HTTP errors now reach the existing scope handlers so collection can continue rather than treating an error body as resource data. Existing rate-limit and GitHub App token-refresh retry behavior is preserved. Previously emitted records are retained; failed scopes can remain incomplete.
Workflow collection also skips
dynamic/paths and drops unavailable file results before job/step parsing, preventing cascading errors when file requests fail. Regression tests exercise successful and failed workflows through both child transformers.Validation: all 424 tests pass on current upstream/main, including parallel organization/repository/environment continuation, partial pagination, GraphQL recovery and exhaustion, rate limits, token refresh, and enterprise credential exports. Ruff and diff checks pass.
Summary by CodeRabbit