Skip to content

Fix: update old versions and skip probe_ids/version from json check #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alejoe91 merged 2 commits into from
Jul 15, 2026
Merged

Fix: update old versions and skip probe_ids/version from json check #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6c41da
Fix: update old versions and skip probe_ids/version from json check
alejoe91 Jul 15, 2026
b88bf09
Fix: update old versions and skip probe_ids/version from json check 2
alejoe91 Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion neuronexus/A4x8-5mm-100-200-177/A4x8-5mm-100-200-177.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"specification": "probeinterface",
"version": "0.2.19",
"version": "0.3.2",
"probes": [
{
"ndim": 2,
Expand Down
2 changes: 1 addition & 1 deletion neuronexus/A4x8-5mm-100-400-177/A4x8-5mm-100-400-177.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"specification": "probeinterface",
"version": "0.2.17",
"version": "0.3.2",
"probes": [
{
"ndim": 2,
Expand Down
2 changes: 1 addition & 1 deletion neuronexus/A4x8-5mm-100-400-703/A4x8-5mm-100-400-703.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"specification": "probeinterface",
"version": "0.2.17",
"version": "0.3.2",
"probes": [
{
"ndim": 2,
Expand Down
2 changes: 1 addition & 1 deletion neuronexus/A4x8-5mm-200-400-177/A4x8-5mm-200-400-177.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"specification": "probeinterface",
"version": "0.2.19",
"version": "0.3.2",
"probes": [
{
"ndim": 2,
Expand Down
2 changes: 1 addition & 1 deletion neuronexus/A4x8-5mm-200-400-703/A4x8-5mm-200-400-703.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"specification": "probeinterface",
"version": "0.2.19",
"version": "0.3.2",
"probes": [
{
"ndim": 2,
Expand Down
2 changes: 1 addition & 1 deletion neuronexus/A4x8-5mm-50-200-177/A4x8-5mm-50-200-177.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"specification": "probeinterface",
"version": "0.2.19",
"version": "0.3.2",
"probes": [
{
"ndim": 2,
Expand Down
2 changes: 1 addition & 1 deletion plexon/4S1024/4S1024.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"specification": "probeinterface",
"version": "0.2.23",
"version": "0.3.2",
"probes": [
{
"ndim": 2,
Expand Down
2 changes: 1 addition & 1 deletion plexon/8S1024/8S1024.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"specification": "probeinterface",
"version": "0.2.23",
"version": "0.3.2",
"probes": [
{
"ndim": 2,
Expand Down
17 changes: 11 additions & 6 deletions scripts/check_for_json_changes_in_probes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from argparse import ArgumentParser
from pathlib import Path
import json
import shutil


Expand Down Expand Up @@ -37,13 +38,17 @@
if old_probe_json_path.is_file():
with open(temp_probe_json_path, 'r') as f1, open(old_probe_json_path, 'r') as f2:
# Read in json files
lines1 = f1.readlines()
lines2 = f2.readlines()
new_probe_dict = json.load(f1)
old_probe_dict = json.load(f2)

# We don't want to update the probes just because of a probeinterface version update.
# The probeinterface version is stored on the 3rd line of the json file, so we only
# compare the json files from line 3 and down.
if lines1[3:] == lines2[3:]:
# We don't want to update the probes just because of a probeinterface version update
# or because a `probe_ids` entry was added (both are introduced automatically by newer
# probeinterface versions), so we ignore those keys when comparing.
for probe_dict in (new_probe_dict, old_probe_dict):
probe_dict.pop("version", None)
probe_dict.pop("probe_ids", None)

if new_probe_dict == old_probe_dict:
continue
else:
shutil.copy(f"{temp_probe_json_path}", old_dir / probe_name)
Expand Down
Loading