Skip to content

Fix sorting times segment propagation #4796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoeZiminski wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −0
Open

Fix sorting times segment propagation #4796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/spikeinterface/core/numpyextractors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,6 +304,9 @@ def from_sorting(source_sorting: BaseSorting, with_metadata=False, copy_spike_ve
sorting = NumpySorting(spike_vector, source_sorting.get_sampling_frequency(), source_sorting.unit_ids.copy())
if source_sorting.has_recording():
sorting._recording = source_sorting._recording
for source_segment, target_segment in zip(source_sorting._sorting_segments, sorting._sorting_segments):
target_segment._t_start = source_segment._t_start
target_segment._native_t_start = source_segment._native_t_start
if with_metadata:
source_sorting.copy_metadata(sorting)
return sorting
Expand Down
16 changes: 16 additions & 0 deletions src/spikeinterface/core/tests/test_numpy_extractors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,22 @@ def test_NumpySorting(setup_NumpyRecording):
sorting = NumpySorting.from_sorting(other_sorting)
# print(sorting)

# Verify recording segment offsets and shifted sorting times survive conversion to NumpySorting.
recording = generate_recording(num_channels=2, durations=[1.0, 1.0])
recording.shift_times(shift=5.0, segment_index=0)
recording.shift_times(shift=120.0, segment_index=1)
other_sorting.register_recording(recording)
other_sorting.shift_times(2.0)
sorting_with_times = NumpySorting.from_sorting(other_sorting)

for segment_index in range(other_sorting.get_num_segments()):
assert sorting_with_times.get_start_time(segment_index) == other_sorting.get_start_time(segment_index)
for unit_id in other_sorting.unit_ids:
assert np.array_equal(
sorting_with_times.get_unit_spike_train(unit_id, segment_index=segment_index, return_times=True),
other_sorting.get_unit_spike_train(unit_id, segment_index=segment_index, return_times=True),
)

# construct back from kwargs keep the same array
sorting2 = load(sorting.to_dict())
assert np.shares_memory(sorting2._cached_spike_vector, sorting._cached_spike_vector)
Expand Down
Loading