fix(core): Wildcard transformation exceptions#622
Closed
Fritx22 wants to merge 1 commit into
Closed
Conversation
* Fix SingleConfigurationTransformation not throwing ConfigurateException exceptions when applying an action to a wildcard path, unlike when applying it to paths without wildcard * Add tests covering all ConfigurateException exceptions thrown while processing a transformation
Author
|
Closing in favor of #623, I forgot to create a separate branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When applying a transformation to a wildcard path in
SingleConfigurationTransformationtheConfigurateExceptionexceptions are caught but are never thrown again after processing all the children nodes. Therefore, this bug prevents the action from purposefully aborting a transformation or automatically aborting the transformation when an unexpected exception is thrown. This will result in a "successful" transformation but the configuration will be partially upgraded.Unlike in this case, transformations applied to non-wildcard paths throw the exceptions as expected.
This pull request fixes this issue and adds tests covering all
ConfigurateExceptionexceptions that can be thrown while processing a transformation, including the suppressed exceptions.The tests
testSingleTransformationWildcardMapThrowsConfigurateException()andtestSingleTransformationWildcardListThrowsConfigurateException()fail without the fix. After applying the fix and building the project all tests and checkstyle checks pass.