Conversation
mgravell
marked this pull request as ready for review
March 16, 2026 11:30
uglide
reviewed
Jul 8, 2026
uglide
left a comment
uglide
left a comment
Contributor
There was a problem hiding this comment.
The main missing peaces at this stage:
- Circuit breaker/Failure detector on the organic load
- Retries
- Per-member health checks
- Limited configuratbility and deviations in the default values (see inline comments)
* move things around and write core * bucket logic * buildable * nit * add unit tests * end-to-end tests * docs * improve circuit-breaker reactivity * gate health-checks, since it can now run concurrently due to circuit-breaker * end-to-end tests
- fix public API for updated lib
* start dedup core * find classes * start stubbing class * successfully stub out all methods (it compiles!) * stub out execute and tuples * generalize mutator API to include channels * wip * fundamentals: compile (untested) * I *think* this is the core retry logic! * nit * fix build * iterating on RetryPolicy * nits * start command categorization * cleanup API * duplicate .Database into IDatabaseAsync (from IDatabase) * unit tests * end to end test, but it highlights a design fault * retry logic * nits * end-to-end tests * docs * namespace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initial active:active