Repository navigation
Report a transport connection's failure the way a stream connection's is reported - #3273
Merged
mgravell merged 1 commit intoOct 13, 2026
Merged
Conversation
MDA2AV
marked this pull request as ready for review
October 12, 2026 20:49
mgravell
approved these changes
Oct 13, 2026
Collaborator
|
LGTM; I'm interested how ioxide has found this - I'm assuming this is broadly similar to how SocketSet spikes this, but if ioxide does it better: great! |
Collaborator
|
@MDA2AV also: to emphasize - this API is deliberately |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: integrating the experimental transport seam on ioxide (io_uring runtime) at https://github.com/MDA2AV/ioxide/tree/main/src/clients/ioxide.redis.stackexchange
Issue: when not using the stock transport, there is no notification when a connection dies, ConnectionFailed is not raised and commands awaiting a reply are cancelled insterad of failing with RedisConnectionException.
How this PR fixes it: RecordConnectionFailed only reports failure when _ioStream is set, adding _transportAdopted for when another transport is used instead.
Some more context:
IoxideTunnel.ConnectTransportAsync returns IoxideTransport so StackExchange.Redis takes the transport path and not the stream path, _ioStream stay null for the connection's life.
When the connection dies the check sees that _ioStream is null so the reporting is skipped.