Repository navigation
docs: point every README download link at dl.stackguardian.io - #17
Merged
Merged
Conversation
The Docker one-liner used a shortened install.sh URL, the manual install said to download from the GitHub release, and a note sent older and alternative installs to GitHub. All now name dl.stackguardian.io, which has every release from 1.0.4 on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The install commands already used
dl.stackguardian.io, but three places in the README still sent people elsewhere.What changes
…/install.shis now the fullhttps://dl.stackguardian.io/add-sg-mcp/install.sh.https://dl.stackguardian.io/add-sg-mcp/v<version>/./latestnames the newest version, andSHA256SUMSsits next to the archives.ADD_SG_MCP_DOWNLOAD_URL=…/releases/download/v1.0.3example are gone. One line now saysdl.stackguardian.iohas every release from 1.0.4 on.The
gh attestation verify … --repo StackGuardian/add-sg-mcpline stays, since it verifies a file rather than downloading one.For the reviewer
The README no longer says how to install 1.0.3 or older, which exist only on GitHub. Setting
ADD_SG_MCP_DOWNLOAD_URLto a GitHub release address still works; it is just no longer written down.Testing
prettier --check README.mdpasses.https://dl.stackguardian.io/add-sg-mcp/latestreturnsv1.0.6.v1.0.6/add-sg-mcp-darwin-arm64.tar.gz,v1.0.6/add-sg-mcp-linux-x64.tar.gz,v1.0.6/add-sg-mcp-windows-x64.zipandv1.0.6/SHA256SUMSall return 200.Documentation only, so no changelog entry or version bump.