Skip to content

feat: keep the picker keys on screen and suggest prompts in next steps - #18

Merged
arunim2405 merged 1 commit into
mainfrom
feat/picker-controls-and-prompts
Oct 15, 2026
Merged

arunim2405 merged 1 commit into
mainfrom
feat/picker-controls-and-prompts

Conversation

@arunim2405

Copy link
Copy Markdown
Member

Summary

  • The StackGuardian agent picker shows its keys the whole time: space to select/unselect · enter to continue. Before, clack only showed them after you pressed enter with nothing selected.
  • The closing Next steps note ends with a few prompts to try in your agent (security posture, why a workflow run failed, creating a workflow from a marketplace template, upgrading workflows).
  • CHANGELOG.md entry for 1.0.7 and version bump.

Only the StackGuardian picker in src/sg/commands.ts changed; the upstream add-mcp install picker is untouched. The hint stays in the output after you submit, because it is part of the question text.

Test plan

  • tests/e2e/sg-login-tty.test.ts checks for the hint and the suggested prompts (failed before the change, passes after)
  • bun run typecheck
  • bun run test (22/22 files)
  • Run npx add-sg-mcp by hand and check the picker and the Next steps note

🤖 Generated with Claude Code

The agent picker now shows "space to select/unselect · enter to continue"
under the question, instead of only after an empty submit. The closing
"Next steps" note suggests a few StackGuardian prompts to try.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@arunim2405 arunim2405 left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings.

Reviewed the complete four-file merge-base diff at fe3fb78dd8bf3784eecec1d2a6b3215aa5ae7bc4 (merge base cb52116f0e3a88a589a41139149eda7513491cbb), including the surrounding login/connect installation paths, Clack rendering, and registered PTY test. I found no actionable correctness, security, performance, or maintainability regressions.

Validation in an isolated archive of the exact head with frozen dependencies:

  • bun run typecheck passed.
  • bun run build passed.
  • bun run test passed: 22/22 test files, including terminal login, standalone binary, and installer smoke coverage.
  • GitHub build, test, and platform smoke checks passed.

Residual validation gap: the suggested prompts were checked as CLI output; their live StackGuardian operations were not exercised.

Verdict: approve. Submitted as a comment review because the authenticated account is the PR author and GitHub does not allow self-approval.

@arunim2405
arunim2405 merged commit f0b2834 into main Oct 15, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant