Repository navigation
feat: keep the picker keys on screen and suggest prompts in next steps - #18
Merged
Merged
Conversation
The agent picker now shows "space to select/unselect · enter to continue" under the question, instead of only after an empty submit. The closing "Next steps" note suggests a few StackGuardian prompts to try. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
arunim2405
commented
Oct 15, 2026
arunim2405
left a comment
Member
Author
There was a problem hiding this comment.
No findings.
Reviewed the complete four-file merge-base diff at fe3fb78dd8bf3784eecec1d2a6b3215aa5ae7bc4 (merge base cb52116f0e3a88a589a41139149eda7513491cbb), including the surrounding login/connect installation paths, Clack rendering, and registered PTY test. I found no actionable correctness, security, performance, or maintainability regressions.
Validation in an isolated archive of the exact head with frozen dependencies:
bun run typecheckpassed.bun run buildpassed.bun run testpassed: 22/22 test files, including terminal login, standalone binary, and installer smoke coverage.- GitHub build, test, and platform smoke checks passed.
Residual validation gap: the suggested prompts were checked as CLI output; their live StackGuardian operations were not exercised.
Verdict: approve. Submitted as a comment review because the authenticated account is the PR author and GitHub does not allow self-approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
space to select/unselect · enter to continue. Before, clack only showed them after you pressed enter with nothing selected.CHANGELOG.mdentry for 1.0.7 and version bump.Only the StackGuardian picker in
src/sg/commands.tschanged; the upstreamadd-mcpinstall picker is untouched. The hint stays in the output after you submit, because it is part of the question text.Test plan
tests/e2e/sg-login-tty.test.tschecks for the hint and the suggested prompts (failed before the change, passes after)bun run typecheckbun run test(22/22 files)npx add-sg-mcpby hand and check the picker and the Next steps note🤖 Generated with Claude Code