Fix for issue #364 - #1045
Open
TimothyDJones wants to merge 1 commit into
Open
Conversation
Instead of checking each input parameter for '********' (as in earlier implementation), we create a copy of the *entire* payload, then iterate over each element of the payload. If the parameter is *NOT* '********', then simply use that value; otherwise, if the original value was blank/null, then use that value or delete that parameter altogether.
guzzijones
approved these changes
Sep 2, 2026
Contributor
|
This is a good fix. I have also noticed in the gui when you rerun an action with secret parameters it grabs the invalid ****** instead of leaving it to use the default. It is most annoying with core.remote where we have a private key path as a parameter secret. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of checking each input parameter for
'********'(as in earlier implementation), we create a copy of the entire payload, then iterate over each element of the payload. If the parameter is NOT'********', then simply use that value; otherwise, if the original value was blank/null, then use that value or delete that parameter altogether.