Repository navigation
Stop setting VAPOURSYNTH_EXTRA_PLUGIN_PATH on macOS/Linux (task #61) - #218
Merged
StuartCameronCode merged 2 commits intoNov 18, 2026
Merged
Conversation
…x (task #61) R78 autoloads <deps>/vapoursynth/plugins (<libdir>/plugins), so setting the variable as well loaded every plugin twice: 35 (macOS x64) / 37 (arm64) "Plugin ... already loaded" warnings at the top of every vspipe stderr, which buried real errors (a preview's native crash read as the first warning, task in build_environment that set it again. The app and the test harness were already right. Same 40 plugin namespaces load without it. - dependency_locator: drop the macOS and Linux inserts; Windows keeps it (vs-plugins is not the autoload directory). Unit test pins it per OS. - tests/vspipe_environment_test.rs: vspipe -i under build_environment() must print no "already loaded" line and load the core namespaces (fails with 37 duplicates when the insert is restored). - pipeline_executor: the debug log names the plugin dir and how it loads, instead of logging None on Unix. - format sweep F9 known failure: expect 'vspipe', since without the warnings a native crash reads "vspipe exited with ..." (task #56 removes the entry). - CLAUDE.md / ENGINEERING_NOTES: note the regression and the guard. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…only (task #61) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
StuartCameronCode
force-pushed
the
stuart/61-worker-sets-vapoursynth-extra-plugin-pat
branch
from
November 17, 2026 12:57
177552c to
76aef55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task #61. On macOS and Linux the worker set
VAPOURSYNTH_EXTRA_PLUGIN_PATHto<deps>/vapoursynth/plugins. R78 already autoloads that directory, so every plugin loaded twice. VapourSynth skips the second load, but every vspipe stderr started with 35 (macOS x64) or 37 (arm64)Plugin … already loadedwarnings. Where only the first stderr line is reported (the preview path), those warnings hid the real error; that is how task #56's F9 QTGMC failures showed up asvspipe failed: Warning: Plugin …/libretinex.dylib already loaded.Change
DependencyLocator::build_environment: drop the macOS and Linux inserts ofVAPOURSYNTH_EXTRA_PLUGIN_PATH. Windows keeps its own insert, because its plugins live invs-plugins, which is not the autoload directory. CLAUDE.md already stated this rule; the old inserts were left over from before R78.pipeline_executor.rs: the debug log now names the plugin directory and how it is reached (autoloaded, or via the variable on Windows).ToolLocatordoc comment: says the variable is set on Windows only. The app,WorkerHarnessand the Dart tests already set it on Windows only.format_sweep.dart: the known-failure entry for Address the filter/feature feedback in issue #50 #56's F9 now matchesvspipeinstead ofvspipe failed. Without the warning noise, a native crash readsvspipe exited with …. Address the filter/feature feedback in issue #50 #56 removes this entry, so expect a small conflict with it.Nothing depended on the variable. RIFE, VSNCNN and MoltenVK are loaded by path.
Tests
extra_plugin_path_is_set_on_windows_only.worker/tests/vspipe_environment_test.rs: runsvspipe -iunderbuild_environment(), fails on anyalready loadedline, and checks the core plugin namespaces still load. On macOS arm64 it fails with the old inserts (37 duplicates) and passes with the fix.cargo test: all pass except the Whisper subtitle test, which needs thesmallmodel, not installed on this machine.Not in this PR
The deps
vspipewrapper scripts still exportVAPOURSYNTH_PLUGIN_PATH, which has done nothing since R74. The worker callsvspipe-bindirectly, so the wrapper never sees worker jobs. It can be dropped the next time deps change.🤖 Generated with Claude Code