Skip to content

Stop setting VAPOURSYNTH_EXTRA_PLUGIN_PATH on macOS/Linux (task #61) - #218

Merged
StuartCameronCode merged 2 commits into
mainfrom
stuart/61-worker-sets-vapoursynth-extra-plugin-pat
Nov 18, 2026
Merged

StuartCameronCode merged 2 commits into
mainfrom
stuart/61-worker-sets-vapoursynth-extra-plugin-pat

Conversation

@StuartCameronCode

Copy link
Copy Markdown
Owner

Task #61. On macOS and Linux the worker set VAPOURSYNTH_EXTRA_PLUGIN_PATH to <deps>/vapoursynth/plugins. R78 already autoloads that directory, so every plugin loaded twice. VapourSynth skips the second load, but every vspipe stderr started with 35 (macOS x64) or 37 (arm64) Plugin … already loaded warnings. Where only the first stderr line is reported (the preview path), those warnings hid the real error; that is how task #56's F9 QTGMC failures showed up as vspipe failed: Warning: Plugin …/libretinex.dylib already loaded.

Change

  • DependencyLocator::build_environment: drop the macOS and Linux inserts of VAPOURSYNTH_EXTRA_PLUGIN_PATH. Windows keeps its own insert, because its plugins live in vs-plugins, which is not the autoload directory. CLAUDE.md already stated this rule; the old inserts were left over from before R78.
  • pipeline_executor.rs: the debug log now names the plugin directory and how it is reached (autoloaded, or via the variable on Windows).
  • ToolLocator doc comment: says the variable is set on Windows only. The app, WorkerHarness and the Dart tests already set it on Windows only.
  • format_sweep.dart: the known-failure entry for Address the filter/feature feedback in issue #50 #56's F9 now matches vspipe instead of vspipe failed. Without the warning noise, a native crash reads vspipe exited with …. Address the filter/feature feedback in issue #50 #56 removes this entry, so expect a small conflict with it.
  • CLAUDE.md and ENGINEERING_NOTES: a dated note and a pointer to the new test.

Nothing depended on the variable. RIFE, VSNCNN and MoltenVK are loaded by path.

Tests

  • New unit test extra_plugin_path_is_set_on_windows_only.
  • New worker/tests/vspipe_environment_test.rs: runs vspipe -i under build_environment(), fails on any already loaded line, and checks the core plugin namespaces still load. On macOS arm64 it fails with the old inserts (37 duplicates) and passes with the fix.
  • Local runs on macOS arm64:
    • cargo test: all pass except the Whisper subtitle test, which needs the small model, not installed on this machine.
    • Flutter push-gate integration tests: 126 passed.
  • Linux and Windows have not been run locally; this PR's CI covers them.

Not in this PR

The deps vspipe wrapper scripts still export VAPOURSYNTH_PLUGIN_PATH, which has done nothing since R74. The worker calls vspipe-bin directly, so the wrapper never sees worker jobs. It can be dropped the next time deps change.

🤖 Generated with Claude Code

StuartCameronCode and others added 2 commits November 17, 2026 23:56
…x (task #61)

R78 autoloads <deps>/vapoursynth/plugins (<libdir>/plugins), so setting the
variable as well loaded every plugin twice: 35 (macOS x64) / 37 (arm64)
"Plugin ... already loaded" warnings at the top of every vspipe stderr, which
buried real errors (a preview's native crash read as the first warning, task
in build_environment that set it again. The app and the test harness were
already right. Same 40 plugin namespaces load without it.

- dependency_locator: drop the macOS and Linux inserts; Windows keeps it
  (vs-plugins is not the autoload directory). Unit test pins it per OS.
- tests/vspipe_environment_test.rs: vspipe -i under build_environment() must
  print no "already loaded" line and load the core namespaces (fails with 37
  duplicates when the insert is restored).
- pipeline_executor: the debug log names the plugin dir and how it loads,
  instead of logging None on Unix.
- format sweep F9 known failure: expect 'vspipe', since without the warnings a
  native crash reads "vspipe exited with ..." (task #56 removes the entry).
- CLAUDE.md / ENGINEERING_NOTES: note the regression and the guard.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…only (task #61)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@StuartCameronCode
StuartCameronCode force-pushed the stuart/61-worker-sets-vapoursynth-extra-plugin-pat branch from 177552c to 76aef55 Compare November 17, 2026 12:57
@StuartCameronCode
StuartCameronCode merged commit a799581 into main Nov 18, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant