Repository navigation
test(unblend): fix the vacuous 8 = 10-bit test; exact and real-source depth tests (task #64) - #221
Merged
StuartCameronCode merged 2 commits intoNov 18, 2026
Conversation
StuartCameronCode
force-pushed
the
stuart/64-unblend-srestore-heavy-test-a-10-bit-cop
branch
from
November 18, 2026 02:25
6b32d7d to
068e49c
Compare
…rce test (task #64) The old test compared the 8-bit run with itself until task #50: its job named no inputPixelFormat, so the worker decoded the 10-bit copy as 8-bit. At 10 bits QTGMC rounds differently and srestore's min/max statistics move ~10% of decisions to a neighbouring original, with recovery as good. - Exact: the same picture at 8 and 10 bits (Deinterlace off on a lossless 50p intermediate) gives identical output, sample for sample. - Real source: a 10-bit copy recovers as well as the 8-bit run (luma), with >= 85% of picks the same. - Both 10-bit jobs, and the PAL 4:2:2 one, set inputPixelFormat and assert the output pix_fmt. - The preview test decodes the encode with the preview's own RGB flags (task #56 F8), which had moved the same frame 0.54 levels. Report section 8 corrected (scripts/depth_source.py), CLAUDE.md and ENGINEERING_NOTES updated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…review) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
StuartCameronCode
force-pushed
the
stuart/64-unblend-srestore-heavy-test-a-10-bit-cop
branch
from
November 18, 2026 04:02
068e49c to
9658faf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes task #64: Unblend's heavy test "a 10-bit copy of the source gives the 8-bit result" has failed on every platform since dc9e36c (task #50). It measured 13.08 levels on arm64 and 13.43 on x86.
Cause
Nothing in Unblend regressed. The test was vacuous until task #50.
inputPixelFormat. Before the source model, the worker then decoded the source as 8-bit 4:2:0, so the test compared the 8-bit run with itself (0.000).SrBMaxchanges by up to 31. As a result 30 of 300 decisions change, and 7–11 of 143 output frames take a neighbouring original.The deps version is ruled out: 1.16.0 and the pinned 1.17.0-rc2 give an identical 13.102. Nightly passed on every platform through f4c5f3f and failed on every platform from dc9e36c.
Change
integration_unblend_test.dart: the depth test is now two tests.inputPixelFormatand asserts the output'spix_fmt. This includes the PAL 10-bit 4:2:2 test, which had also been running at 8 bits.accurate_rnd+full_chroma_int. The test now decodes the encode with the same flags, and the difference is 0.00 again.docs/reports/2026-11-srestore: the wrong sentence is struck through, with a correction card. A newscripts/depth_source.py/data/depth_source.jsonmeasures the real 10-bit source.inputPixelFormatand assertpix_fmt.Testing
flutter test --tags heavy test/integration_unblend_test.dartpasses on macOS arm64 with deps 1.17.0-rc2. I ran it twice, with identical numbers.yuv420p, the exact test fails as expected.flutter analyzeis clean on the test file.Follow-ups (separate tasks)
🤖 Generated with Claude Code