Repository navigation
Fix IVTC preview vspipe crash on shutdown and IVTC parity test (task #65) - #224
Open
StuartCameronCode wants to merge 8 commits into
Open
StuartCameronCode wants to merge 8 commits into
StuartCameronCode wants to merge 8 commits into
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…l keeps the worker's status line The parity master has no pulldown, so since the preview decimates in the encode's phase (task #46) IVTC of frame 12 is that frame unchanged (0.000 levels from the passthrough); it passed only while the preview showed the wrong frame. deinterlace_ivtc and ivtc_fix_fades now run on the master telecined 3:2 (5.2 levels from the passthrough, 8 vs 10-bit 0.19). PreviewResult.errorTail leads with the worker's 'Error generating preview:' line (vspipe's exit status) when it has scrolled out of the last four lines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…me at evaluation (task #65) The IVTC / Soft Telecine preview read VDecimate's _PreviewSlot tag with get_frame() while the script was evaluated, running the whole source graph once before vspipe started. The pick between the two candidate outputs is now a FrameEval with prop_src on the probe frame, which prints PREVIEW_DECIMATE:corr when vspipe requests the frame. test_259: the template requests no frame at evaluation (the border swatch excepted). The repro workflow now runs main's template and this one side by side, 4 loops each under CPU load. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rden the repro script's rm Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…er side and mode Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…n race; remove the temporary repro workflow Measured on CI: with four previews at a time under CPU load, main's template crashed vspipe in 2-3% of x86 IVTC previews (SIGSEGV in outputFrame / frameDoneCallback during freeScript), this branch's 0 in 3960. vspipe R78 counts a frame done before writing it (fixed upstream in R80); the evaluation-time get_frame made the preview's frame ready at once. The workflow is kept in the report's scripts/. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two IVTC heavy failures from nightly 43909344002 (main @ dc9e36c, 2026-11-16). Both came from task #46, which made the IVTC / Soft Telecine preview run VDecimate in the encode's phase.
1. "IVTC on 10-bit ProRes" preview exits 1 (vspipe crashes on shutdown)
frameDoneCallbackcounts a frame as done before it writes it. If the one requested frame is already finished when the main thread reacheswait, vspipe frees the script under the callback, which still holds the frame, and segfaults. Fixed upstream in 4ff3f8a0 (R80).get_frame()while the script was being set up. That computed the target's frames in advance, so the preview frame was ready the moment vspipe asked for it._preview_decimate_pickis aFrameEvalwithprop_srcset to the frame where the target would be, and it picks between the two outputs the worker computed. It printsPREVIEW_DECIMATE:corr=Nat frame time. The change is preview-only, so encodes are unchanged.previewErrorTailnow keeps the worker'sError generating preview:status line. In the nightly it had scrolled out of the tail behind plugin warnings.2. "8-bit vs 10-bit result parity deinterlace_ivtc" equals passthrough
The parity master has no pulldown, so IVTC of frame 12 is frame 12 unchanged (0.000 levels from the passthrough). The case only "changed the picture" before because the preview showed the wrong frame. It now runs on the master telecined 3:2 (
_telecineFixture): 5.2 levels from the passthrough, and 0.19 between 8-bit and 10-bit.ivtc_fix_fadesuses the same fixture.Tests
test_259: the template requests no frame while the script is being set up (only the border colour's one-frame swatch is allowed), and the decimating preview picks its frame in the graph.test_55andtest_251are updated to the new emitted text.preview_error_tail_test.dart(unit test).test_259is the guard.deinterlace_ivtcandivtc_fix_fadespassDocs
docs/reports/task-65-ivtc-preview-teardown, with its scripts, the backtrace and per-platform data.🤖 Generated with Claude Code