Add a switch to turn the global hotkey off#66
Merged
Conversation
Settings gains an "Enabled" checkbox alongside the global-hotkey chord. The choice persists in app config (AppConfig.HotkeyEnabled, default true so existing settings files keep their hotkey) and is observed immediately: clearing the box unregisters the hotkey and disables the capture box; ticking it re-registers the stored chord. Reset now also switches the hotkey back on and restores Ctrl+Alt+S. Startup skips registration when the hotkey is disabled. Also suppress the transitive SQLitePCLRaw.lib.e_sqlite3 advisory (GHSA-2m69-gcr7-jv3q) that TreatWarningsAsErrors turns into a hard restore failure; the fix is a SQLitePCLRaw major bump Microsoft.Data.Sqlite 10.x doesn't yet bind, and Snipdeck only ever opens its own local history.db. Bumps the minor version to 1.1.0 and promotes the changelog. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a setting to turn the global hotkey on/off, per request. In Settings → Global hotkey there is now an Enabled checkbox next to the chord:
Ctrl+Alt+Sdefault.How it works
AppConfig.HotkeyEnabled(defaults totrue, so existing settings files keep their hotkey — no schema bump needed since the field is purely additive and older builds simply ignore it).SettingsViewModel.HotkeyEnabledobservable persists and registers/unregisters on change; the change handler is inert during construction (respects_suppressPersist) so opening Settings never re-registers.App.InitialiseHotkey) skips registration when disabled.Incidental: unblock the build
Microsoft.Data.Sqlite10.0.9 transitively pullsSQLitePCLRaw.lib.e_sqlite32.1.11, which a newly-published advisory (NU1903/ GHSA-2m69-gcr7-jv3q) now flags. WithTreatWarningsAsErrorsthis failsrestoreonmaintoo, unrelated to this change. The patched native lib is a SQLitePCLRaw 2.x→3.x major jump thatMicrosoft.Data.Sqlite10.x doesn't yet bind (11.x is preview-only), so this adds a scoped, documentedNuGetAuditSuppressfor the advisory ID. The vuln concerns native SQLite parsing of untrusted DB files; Snipdeck only ever opens its own localhistory.db. Remove onceMicrosoft.Data.Sqliteships a patched bundle.Version
Bumps the minor version to 1.1.0 and promotes the changelog.
Testing
Snipdeck.Core.Tests: 245 pass, including 5 new tests covering initial enabled state, disable→unregister+persist, enable→register+persist, enable-with-registration-failure error, and Reset re-enabling when off.🤖 Generated with Claude Code