Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validate_field_name()accepts names such asclass,returnandNonebecausestr.isidentifier()also accepts reserved Python keywords. Those names cannot be used as fields in generated Python signatures. Reject them withkeyword.iskeyword()while preserving valid Unicode identifiers, trailing underscores and soft keywords.Added coverage for every Python keyword and valid-name controls, plus an Unreleased changelog entry. On Python 3.12, the new tests produce 35 failures and 6 passes on the unchanged base; the full test suite and scoped Ruff lint/format checks pass on head
18e9505c9a3ca4e7d00f978c0f9f241134205946in an isolated GitHub Actions runner: https://github.com/ANO3457/practical-ai-systems/actions/runs/40451449756 . No model API was called.AI disclosure: Codex prepared the implementation, regression tests and description, inspected the final diff, and ran/read the checks above. The human operator is ANO3457; no separate personal human code review is claimed.