Skip to content

fix(datagrid): add the Korean translations the result chart strings were missing - #2252

Merged
datlechin merged 1 commit into
mainfrom
fix/korean-chart-strings
Aug 19, 2026
Merged

fix(datagrid): add the Korean translations the result chart strings were missing#2252
datlechin merged 1 commit into
mainfrom
fix/korean-chart-strings

Conversation

@datlechin

Copy link
Copy Markdown
Member

KoreanLocalizationSourceTests fails on main, so every open PR shows a red macOS App Tests. It is not caused by any of them.

Twenty-seven result-chart strings reached the catalog with tr, vi, zh-Hans and zh-Hant but no ko. The chart work and the Korean localization landed in the same unreleased cycle, and the guard that requires a Korean value for every translatable entry arrived with the latter. My commit in #2222 is where the untranslated keys came from.

Without this, a Korean user sees the entire chart feature in English: the mode label, both axis pickers, all four chart type names, and every empty and limit notice.

The two entries that needed care

%1$@ chart of %2$@ by %3$@ with %4$d points is the only one of the 27 with an en localization, and that value is %1$@ chart of %2$@ by %3$@ with %#@points@, a plural substitution. translationsPreserveStructure compares the Korean format signature against the en value rather than against the key, so spelling %4$d in Korean fails: the substitution token carries no specifier the regex can see, giving three arguments on one side and four on the other. Korean therefore mirrors the substitution structure, with a single other category since Korean has no plural distinction.

Note in passing that tr, vi and both Chinese variants all spell that key with %4$d against an en source using %#@points@. The guard only inspects Korean, so it does not catch them. Separately, the Vietnamese value for Charting the first %1$@ of %2$@ loaded rows uses %1$d where every other language and the key itself use %1$@. Neither is in scope here, but both are real and neither is currently guarded.

Terminology

Matched to what the catalog already uses rather than chosen fresh: Bar is 막대, so Line / Area / Scatter are 선 / 영역 / 분산형; Rows is 행 and Columns is 열, so the row-number axis label and the column picker follow those; %d rows is %d개 행, so the count notices keep the 개 counter.

Verification

  • 178 insertions, 0 deletions. The catalog is edited as text, not re-serialized: Xcode's key collation differs from a plain codepoint sort, so a round-trip through json.dumps reorders the file. I measured that before touching it, having reformatted this same catalog into a 142,790-line diff once before.
  • KoreanLocalizationSourceTests: 9 executed, 9 passed. Log grepped for Failing tests:, TEST FAILED and Crash:, 0 hits.
  • Debug build PASS.

No CHANGELOG entry

Both the chart feature and Korean localization are still under [Unreleased]. CLAUDE.md says not to add a Fixed entry for something that is itself unreleased, and the existing "Korean localization for macOS, iPhone and iPad" line already covers what ships.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@datlechin
datlechin merged commit 03aea22 into main Aug 19, 2026
8 checks passed
@datlechin
datlechin deleted the fix/korean-chart-strings branch August 19, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant