fix(datagrid): add the Korean translations the result chart strings were missing - #2252
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KoreanLocalizationSourceTestsfails onmain, so every open PR shows a redmacOS App Tests. It is not caused by any of them.Twenty-seven result-chart strings reached the catalog with
tr,vi,zh-Hansandzh-Hantbut noko. The chart work and the Korean localization landed in the same unreleased cycle, and the guard that requires a Korean value for every translatable entry arrived with the latter. My commit in #2222 is where the untranslated keys came from.Without this, a Korean user sees the entire chart feature in English: the mode label, both axis pickers, all four chart type names, and every empty and limit notice.
The two entries that needed care
%1$@ chart of %2$@ by %3$@ with %4$d pointsis the only one of the 27 with anenlocalization, and that value is%1$@ chart of %2$@ by %3$@ with %#@points@, a plural substitution.translationsPreserveStructurecompares the Korean format signature against theenvalue rather than against the key, so spelling%4$din Korean fails: the substitution token carries no specifier the regex can see, giving three arguments on one side and four on the other. Korean therefore mirrors the substitution structure, with a singleothercategory since Korean has no plural distinction.Note in passing that
tr,viand both Chinese variants all spell that key with%4$dagainst anensource using%#@points@. The guard only inspects Korean, so it does not catch them. Separately, the Vietnamese value forCharting the first %1$@ of %2$@ loaded rowsuses%1$dwhere every other language and the key itself use%1$@. Neither is in scope here, but both are real and neither is currently guarded.Terminology
Matched to what the catalog already uses rather than chosen fresh:
Baris 막대, soLine/Area/Scatterare 선 / 영역 / 분산형;Rowsis 행 andColumnsis 열, so the row-number axis label and the column picker follow those;%d rowsis%d개 행, so the count notices keep the 개 counter.Verification
json.dumpsreorders the file. I measured that before touching it, having reformatted this same catalog into a 142,790-line diff once before.KoreanLocalizationSourceTests: 9 executed, 9 passed. Log grepped forFailing tests:,TEST FAILEDandCrash:, 0 hits.No CHANGELOG entry
Both the chart feature and Korean localization are still under
[Unreleased]. CLAUDE.md says not to add a Fixed entry for something that is itself unreleased, and the existing "Korean localization for macOS, iPhone and iPad" line already covers what ships.