Repository navigation
fix(linux): keep imported ids and empty strings, batch CSV import, XLSX - #3472
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build_insertwrites every given value except generated columns, so an imported id is kept. A generated column, a PostgreSQLGENERATED ALWAYSidentity or a SQL ServerIDENTITYcolumn can't be mapped; the dialog greys it out with "The database fills this column". SQL Server'sIDENTITY_INSERTis session state on a pooled connection, so it is refused rather than toggled.HistorybecomesHistory_.null.VALUESstatements under each engine's limits (SQL Server 1,000 rows and 2,000 parameters; ClickHouse 1,000 parameters and 8 KiB of values, since its parameters travel in the URL). Each statement adds 5 s to the save deadline. Failures name file lines; on a table without transactions the message says part may have landed.ImportLedgerholds the process, inhibits logout and suspend, and asks "Stop Imports?" on close.0001-01-01 BC, offset seconds are kept.=""formula.