Skip to content

fix(plugins): pick between plugin copies by build number - #3494

Merged
datlechin merged 1 commit into
mainfrom
fix/plugin-copy-by-build
Oct 18, 2026
Merged

datlechin merged 1 commit into
mainfrom
fix/plugin-copy-by-build

Conversation

@datlechin

@datlechin datlechin commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

Why

When a plugin is both bundled and installed in the user folder, discovery picked the copy with the higher CFBundleShortVersionString. A stale registry copy of a bundled driver could beat the built-in one; five bundled plugins carry hand-set marketing versions to prevent it.

Change

  • Discovery picks the copy with the higher CFBundleVersion, read from disk. A tie goes to the built-in copy, and the losing user copy is pruned as before.
  • PluginEntry carries the build.
  • Deleted the unused bundleVersion(at:) and the one-time com.TablePro.needsRestart cleanup.

Verified

New PluginWinnerSelectionTests (lower build loses, higher wins, tie goes to built-in) and bundleBuild(at:) cases in PluginBundleVersionTests.

Not in this PR

@datlechin
datlechin merged commit e9716fe into main Oct 18, 2026
8 checks passed
@datlechin
datlechin deleted the fix/plugin-copy-by-build branch October 18, 2026 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant