Repository navigation
fix(plugins): pick between plugin copies by build number - #3494
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When a plugin is both bundled and installed in the user folder, discovery picked the copy with the higher
CFBundleShortVersionString. A stale registry copy of a bundled driver could beat the built-in one; five bundled plugins carry hand-set marketing versions to prevent it.Change
CFBundleVersion, read from disk. A tie goes to the built-in copy, and the losing user copy is pruned as before.PluginEntrycarries the build.bundleVersion(at:)and the one-timecom.TablePro.needsRestartcleanup.Verified
New
PluginWinnerSelectionTests(lower build loses, higher wins, tie goes to built-in) andbundleBuild(at:)cases inPluginBundleVersionTests.Not in this PR
development/testing-plugins.mdx:21still says the higher version wins at discovery. It becomes "the higher build (CFBundleVersion) wins" in the docs PR that rewrites that page for the v3 manifest.PluginManager.init'suserDefaultsparameter is now unused. Dropping it editsPluginManager.shared, the line next to refactor(plugins): stamp the PluginKit version from one build setting #3498's change, andPluginLazyActivationVerificationTests, so it follows refactor(plugins): stamp the PluginKit version from one build setting #3498.