Repository navigation
test(linux): drop imported open times and fix two test races - #3500
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
linuxCI has been red since #3467. Fast checks, Flatpak and every package job faila_version_1_connection_list_imports_as_it_was_written. #3467 made an import drop a file's last-opened times, and #3464's fixture test still expected them. Since #3473, two app tests also time out on some jobs.Change
an_unreadable_history_says_why_where_it_is_openedwaits forwin.show-historyto turn on. The action follows the window's own history, which can still be opening, and activating a disabled action does nothing.a_sorted_table_pages_by_offsetserves a count of 1,000, like its sibling paging tests. With the old count of 2, a count landing after Next moved the pager back to the first page. That made a fourth read, and the wait for exactly three missed it.Verified
stored_formatsfails onlinuxand passes here. fmt, clippy and thetableprolib suite pass in the Linux dev image, exceptsorting_10k_text_rows_finishes_within_one_second, which missed its 1 s bound at load average 56 and passes alone. Neither timeout reproduced locally; both races come from reading the code.