Update blender_thumbnailer.py to read Blender 5.x files by 050011-code · Pull Request #1481 · TagStudioDev/TagStudio

050011-code · 2026-08-16T12:03:13Z

Summary

Updates blender_thumbnailer.py to read Blender 5.x files.

Refactor blender_thumbnailer.py to improve readability and maintainability. (Declaring this bit as AI made)

Handle file operations more safely.

Tasks Completed

Platforms Tested:
- Windows x86
- Windows ARM
- macOS x86
- macOS ARM
- Linux x86
- Linux ARM
Tested For:
- Basic functionality
- PyInstaller executable

Updates blender_thumbnailer.py to read Blender 5.x files. Also refactor blender_thumbnailer.py to improve readability and maintainability. (Declaring this bit as AI made) Handle file operations more safely.

050011-code · 2026-08-16T12:04:31Z

Thats on me for not remembering to fix the formating
Looks like I also massacred the attribution

050011-code · 2026-08-16T12:06:54Z

I'm sorry I was trying to make this pull request on my own fork!

There are still errors as its current state was not meant to be for the original repo

Refactor blender_thumbnailer.py to use type hints and improve readability.

Removed unnecessary logging statements to clean up code.

Updated image resizing method to use Image.Resampling.BICUBIC.

CyanVoxel · 2026-08-17T20:01:34Z

(Declaring this bit as AI made)

Thank you for your willingness to contribute and fix this issue. Before I start making review comments on this, I'd like to cite our CONTRIBUTING.md's "Unacceptable Code" section:

Unacceptable Code
The following types of code will NOT be accepted to the project:

[...]

Code that you do not understand and/or cannot explain (i.e. "vibe coding")

If you're not able to explain why you made specific changes in this (preferably with sources from Blender where applicable) then I'm afraid I won't review this as per our contributing policy. If you do know what you're doing with these changes and are open to me (heavily) scrutinizing the AI-assisted changes, then I'll go ahead with an in-depth review. I wouldn't pester you over exact undocumented byte ranges as long as they work, but every other change I'd want explanations for.

Also, I just pulled this to actually give it a quick test, and it's not working with my Blender 5.x test file:
[info ] [ThumbRenderer][BLENDER][INFO] blender_5.blend Doesn't have an embedded thumbnail.

CyanVoxel · 2026-08-17T21:27:51Z

+    finally:
+        if blendfile is not None:
+            blendfile.close()

-    return image_buffer, x, y
+        if raw_file is not None and raw_file is not blendfile:
+            raw_file.close()


If all you're doing with the try finally block is to manage opening and closing files, you should instead use "with" context managers

CyanVoxel · 2026-08-17T21:29:02Z

+        # --------------------------------------------------------------
+        # Open file.
+        # --------------------------------------------------------------


Unnecessary to add three lines of comments to a self-explaining line of code (this comment style is a pattern in this PR)

Suggested change

# --------------------------------------------------------------

# Open file.

# --------------------------------------------------------------

CyanVoxel · 2026-08-17T21:29:57Z

+        # --------------------------------------------------------------
+        # GZIP-compressed blend file.
+        # --------------------------------------------------------------


Unnecessary to have fluff comments like these lines

Suggested change

# --------------------------------------------------------------

# GZIP-compressed blend file.

# --------------------------------------------------------------

# GZIP-compressed blend file.

CyanVoxel · 2026-08-17T21:30:23Z

+        # --------------------------------------------------------------
+        # Walk the BHeads until we find TEST.
+        # --------------------------------------------------------------


Suggested change

# --------------------------------------------------------------

# Walk the BHeads until we find TEST.

# --------------------------------------------------------------

# Walk the BHeads until we find TEST.

CyanVoxel · 2026-08-17T21:30:52Z

+            # ----------------------------------------------------------
+            # REND contains render information before TEST.
+            # Skip its payload.
+            # ----------------------------------------------------------


Suggested change

# ----------------------------------------------------------

# REND contains render information before TEST.

# Skip its payload.

# ----------------------------------------------------------

# REND contains render information before TEST, skip its payload.

CyanVoxel · 2026-08-17T21:58:18Z

-        if code == rend:
-            blendfile.seek(length, os.SEEK_CUR)
+            # ----------------------------------------------------------
+            # Blender 5+ BHead


Nit: Make version numbers consistent with one another

Suggested change

# Blender 5+ BHead

# Blender 5.0+ BHead

CyanVoxel · 2026-08-17T21:59:46Z

+            code: bytes = bhead[:4]
+
+            # ----------------------------------------------------------
+            # Blender 5+


Suggested change

# Blender 5+

# Blender 5.0+

CyanVoxel · 2026-08-17T22:00:59Z

+                length: int = struct.unpack_from(
+                    "<Q",
+                    bhead,
+                    16,
+                )[0]


This can be one line

Suggested change

length: int = struct.unpack_from(

"<Q",

bhead,

16,

)[0]

length: int = struct.unpack_from("<Q", bhead, 16)[0]

CyanVoxel · 2026-08-17T22:01:24Z

+                length = struct.unpack_from(
+                    int_endian + "i",
+                    bhead,
+                    4,
+                )[0]


This can be one line

Suggested change

length = struct.unpack_from(

int_endian + "i",

bhead,

4,

)[0]

length = struct.unpack_from(int_endian + "i", bhead, 4)[0]

CyanVoxel · 2026-08-17T22:01:54Z

+            x, y = struct.unpack(
+                int_endian_pair,
+                dimensions,
+            )


Suggested change

x, y = struct.unpack(

int_endian_pair,

dimensions,

)

x, y = struct.unpack(int_endian_pair, dimensions)

Update blender_thumbnailer.py to read Blender 5.x files

39d733d

Updates blender_thumbnailer.py to read Blender 5.x files. Also refactor blender_thumbnailer.py to improve readability and maintainability. (Declaring this bit as AI made) Handle file operations more safely.

050011-code marked this pull request as draft August 16, 2026 12:07

050011-code added 4 commits August 16, 2026 22:34

Add type hints and clean up blender_thumbnailer.py

c7ac68f

Refactor blender_thumbnailer.py to use type hints and improve readability.

Clean up logging in blender_thumbnailer.py

4dff491

Removed unnecessary logging statements to clean up code.

ruff format hopefully

b5222ee

Final format

6b9e184

Updated image resizing method to use Image.Resampling.BICUBIC.

050011-code marked this pull request as ready for review August 17, 2026 02:08

CyanVoxel added Type: UI/UX User interface and/or user experience Priority: Low Doesn't require immediate attention Status: Review Needed A review of this is needed TagStudio: Thumbs/Previews File thumbnails or previews labels Aug 17, 2026

CyanVoxel added this to TagStudio Development Aug 17, 2026

CyanVoxel added this to the Alpha v9.6.4 milestone Aug 17, 2026

CyanVoxel moved this to 🏓 Ready for Review in TagStudio Development Aug 17, 2026

CyanVoxel requested changes Aug 17, 2026

View reviewed changes

CyanVoxel removed the Status: Review Needed A review of this is needed label Aug 17, 2026

CyanVoxel moved this from 🏓 Ready for Review to 👀 In review in TagStudio Development Aug 17, 2026

	# --------------------------------------------------------------
	# Open file.
	# --------------------------------------------------------------

Uh oh!

Uh oh!

Conversation

050011-code commented Aug 16, 2026

Summary

Tasks Completed

Uh oh!

050011-code commented Aug 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

050011-code commented Aug 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CyanVoxel commented Aug 17, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

050011-code commented Aug 16, 2026 •

edited

Loading

050011-code commented Aug 16, 2026 •

edited

Loading