fix: preserve multimodal tool results across client round trips - #1284
Draft
sravan-v wants to merge 6 commits into
Draft
fix: preserve multimodal tool results across client round trips#1284sravan-v wants to merge 6 commits into
sravan-v wants to merge 6 commits into
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Fixes #1283.
TOOL_CALL_RESULTarrives with the tool output serialized as a string. When that string contains a validContentPart[], keeping it as plain text means the structured result is lost beforeuiMessagesToWirebuilds the next request.This change restores valid content-part arrays while leaving ordinary string and JSON tool results unchanged. It also adds regression coverage for the stream-processor → wire round trip, including the e2e suite.
No docs change: this restores the existing multimodal tool-result behavior rather than adding a new API.
✅ Checklist
pnpm run test:prdocs/for this change, or this change is not user-facing🚀 Release Impact
Local
pnpm test:prwas not run in this environment; the PR checks are expected to validate the test, typecheck, lint, and build paths.