Make every catalog example self-contained - #100
Merged
Conversation
|
Important Review skippedToo many files! This PR contains 625 files, which is 475 over the limit of 150. To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (25)
📒 Files selected for processing (625)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
tannerlinsley
force-pushed
the
taren/catalog-self-contained-examples
branch
from
August 14, 2026 19:56
e99c2b6 to
02509a7
Compare
|
View your CI Pipeline Execution ↗ for commit 02509a7
☁️ Nx Cloud last updated this comment at |
![nx-cloud[bot]](https://avatars.githubusercontent.com/in/80458?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud is proposing a fix for your failed CI:
We updated the title fields in five case.json files (128–132) to match the lowercase/em-dash labels already present in docs/config.json, which the PR had introduced but not propagated back to the source metadata. This resolves the charts-workspace:docs-check assertion failure, where scripts/docs-catalog-navigation.mjs compares docs/config.json children against labels generated from case.json titles and found them out of sync.
Tip
✅ We verified this fix by re-running charts-workspace:docs-check.
Suggested Fix changes
diff --git a/benchmarks/conformance/cases/128-shadcn-bar-multiple/case.json b/benchmarks/conformance/cases/128-shadcn-bar-multiple/case.json
index 9e39ce8..403948c 100644
--- a/benchmarks/conformance/cases/128-shadcn-bar-multiple/case.json
+++ b/benchmarks/conformance/cases/128-shadcn-bar-multiple/case.json
@@ -5,7 +5,7 @@
"height": 600,
"order": 1290,
"id": "128-shadcn-bar-multiple",
- "title": "shadcn Bar Chart - Multiple",
+ "title": "shadcn bar chart – multiple",
"family": "bar",
"intent": "Reproduce shadcn/ui's chart-bar-multiple example with TanStack Charts.",
"support": "native",
diff --git a/benchmarks/conformance/cases/129-shadcn-pie-donut-text/case.json b/benchmarks/conformance/cases/129-shadcn-pie-donut-text/case.json
index 8e93cdb..41a61a7 100644
--- a/benchmarks/conformance/cases/129-shadcn-pie-donut-text/case.json
+++ b/benchmarks/conformance/cases/129-shadcn-pie-donut-text/case.json
@@ -5,7 +5,7 @@
"height": 600,
"order": 1300,
"id": "129-shadcn-pie-donut-text",
- "title": "shadcn Pie Chart - Donut with Text",
+ "title": "shadcn pie chart – donut with text",
"family": "pie",
"intent": "Reproduce shadcn/ui's chart-pie-donut-text example with TanStack Charts.",
"support": "native",
diff --git a/benchmarks/conformance/cases/130-shadcn-radar-multiple/case.json b/benchmarks/conformance/cases/130-shadcn-radar-multiple/case.json
index db3ecb3..97923ea 100644
--- a/benchmarks/conformance/cases/130-shadcn-radar-multiple/case.json
+++ b/benchmarks/conformance/cases/130-shadcn-radar-multiple/case.json
@@ -5,7 +5,7 @@
"height": 600,
"order": 1310,
"id": "130-shadcn-radar-multiple",
- "title": "shadcn Radar Chart - Multiple",
+ "title": "shadcn radar chart – multiple",
"family": "radar",
"intent": "Reproduce shadcn/ui's chart-radar-multiple example with TanStack Charts.",
"support": "native",
diff --git a/benchmarks/conformance/cases/131-shadcn-radial-text/case.json b/benchmarks/conformance/cases/131-shadcn-radial-text/case.json
index 2e6b199..ea4afe6 100644
--- a/benchmarks/conformance/cases/131-shadcn-radial-text/case.json
+++ b/benchmarks/conformance/cases/131-shadcn-radial-text/case.json
@@ -5,7 +5,7 @@
"height": 600,
"order": 1320,
"id": "131-shadcn-radial-text",
- "title": "shadcn Radial Chart - Text",
+ "title": "shadcn radial chart – text",
"family": "radial",
"intent": "Reproduce shadcn/ui's chart-radial-text example with TanStack Charts.",
"support": "native",
diff --git a/benchmarks/conformance/cases/132-shadcn-tooltip-advanced/case.json b/benchmarks/conformance/cases/132-shadcn-tooltip-advanced/case.json
index fab1021..510019d 100644
--- a/benchmarks/conformance/cases/132-shadcn-tooltip-advanced/case.json
+++ b/benchmarks/conformance/cases/132-shadcn-tooltip-advanced/case.json
@@ -5,7 +5,7 @@
"height": 600,
"order": 1330,
"id": "132-shadcn-tooltip-advanced",
- "title": "shadcn Tooltip - Advanced",
+ "title": "shadcn tooltip – advanced",
"family": "tooltip",
"intent": "Reproduce shadcn/ui's chart-tooltip-advanced example with TanStack Charts.",
"support": "native",
Or Apply changes locally with:
npx nx-cloud apply-locally gaMh-cCMG
Apply fix locally with your editor ↗ View interactive diff ↗
🎓 Learn more about Self-Healing CI on nx.dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on TanStack/tanstack.com#1159. Merge that compatibility PR first.\n\nMigrates all 188 catalog cases to a public, self-contained example.tsx entry. Sandbox source now opens on the actual chart definition and includes only the example's relative dependency closure. Conformance adapters import those public definitions, keeping the test machinery DRY and out of user-facing workspaces.\n\nAlso adds generated-example cleanup and contract checks, moves reusable public datasets into charts-demo-data, removes obsolete ShadCN reference/view layers, and publishes the smaller schema-v2 catalog index.\n\nValidation:\n- 188/188 public example contracts; maximum TypeScript closure 4 files\n- 188/188 preview generation and validation\n- 188-case conformance quick audit; 22/22 interaction cases\n- 70/70 ShadCN visual comparisons; 97.5% mean similarity\n- 1,878 tests, typecheck, formatting, diff checks\n- production conformance catalog build