Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/bump-devtools-event-client.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/form-core': patch
---

Bump `@tanstack/devtools-event-client` to `^0.4.1`.
4 changes: 2 additions & 2 deletions packages/form-core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
},
"scripts": {
"clean": "premove ./dist ./coverage",
"test:eslint": "eslint ./src ./tests",
"test:eslint": "eslint ./src ./tests ./test-build",
"test:types": "pnpm run \"/^test:types:ts[0-9]{2}$/\"",
"test:types:ts54": "node ../../node_modules/typescript54/lib/tsc.js",
"test:types:ts55": "node ../../node_modules/typescript55/lib/tsc.js",
Expand All @@ -26,7 +26,7 @@
"test:types:ts59": "tsc",
"test:lib": "vitest",
"test:lib:dev": "pnpm run test:lib --watch",
"test:build": "publint --strict",
"test:build": "publint --strict && vitest --dir ./test-build --coverage.enabled=false --typecheck.enabled=false",
"build": "vite build"
},
"type": "module",
Expand Down
53 changes: 53 additions & 0 deletions packages/form-core/test-build/bundle.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
import { fileURLToPath } from 'node:url'
import { describe, expect, it } from 'vitest'
import { build } from 'vite'
import type { Rollup } from 'vite'

const entry = fileURLToPath(new URL('../dist/esm/index.js', import.meta.url))

const eventClientPackage = '@tanstack/devtools-event-client'
const eventClientModule = 'plugin.js'

async function bundle(mode: 'production' | 'development') {
const result = (await build({
configFile: false,
logLevel: 'silent',
mode,
define: { 'process.env.NODE_ENV': JSON.stringify(mode) },
build: {
write: false,
minify: false,
lib: { entry, formats: ['es'], fileName: 'index' },
},
})) as Array<Rollup.RollupOutput>

return result
.flatMap((output) => output.output)
.filter((chunk): chunk is Rollup.OutputChunk => chunk.type === 'chunk')
}

function renderedEventClientModules(chunks: Array<Rollup.OutputChunk>) {
return chunks
.flatMap((chunk) => Object.entries(chunk.modules))
.filter(
([id, module]) =>
id.includes(eventClientPackage) &&
id.endsWith(`/${eventClientModule}`) &&
module.renderedLength > 0,
)
.map(([id, module]) => ({ id, renderedLength: module.renderedLength }))
}

describe('bundle', () => {
it('excludes the devtools event client from production bundles', async () => {
const chunks = await bundle('production')

expect(renderedEventClientModules(chunks)).toEqual([])
})

it('includes the devtools event client in development bundles', async () => {
const chunks = await bundle('development')

expect(renderedEventClientModules(chunks)).not.toEqual([])
})
})
8 changes: 7 additions & 1 deletion packages/form-core/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,11 @@
"moduleResolution": "Bundler"
// "noErrorTruncation": true
},
"include": ["src", "tests", "eslint.config.js", "vite.config.ts"]
"include": [
"src",
"tests",
"test-build",
"eslint.config.js",
"vite.config.ts"
]
}
Loading