fix(preact-query): allow retryOnMount when throwOnError is function - #11166
Conversation
Ports TanStack#9338 to preact-query: ensurePreventErrorBoundaryRetry now receives the cached query and evaluates a function-form throwOnError against the actual error before setting retryOnMount = false, instead of treating any function as truthy. Includes the regression tests from TanStack#9338, two of which fail on current main. Fixes TanStack#11165 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (5)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughPreact Query now evaluates functional ChangesPreact retry-on-mount error handling
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This change corrects retry-on-remount behavior for function-based error handling and adds regression coverage; no actionable merge-blocking risk remains after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant useBaseQuery
participant QueryCache
participant ensurePreventErrorBoundaryRetry
participant shouldThrowError
useBaseQuery->>QueryCache: Retrieve cached query by queryHash
useBaseQuery->>ensurePreventErrorBoundaryRetry: Pass options, reset boundary, and query
ensurePreventErrorBoundaryRetry->>shouldThrowError: Evaluate throwOnError with query.error and query
shouldThrowError-->>ensurePreventErrorBoundaryRetry: Return resolved boolean
ensurePreventErrorBoundaryRetry->>useBaseQuery: Apply retryOnMount prevention when resolved value is true
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/preact-query/src/errorBoundaryUtils.ts`:
- Around line 30-33: The throwOnError logic should evaluate the predicate for
every query in an error state, including failures with falsy values such as 0,
empty string, or null. Replace the query.state.error truthiness guard with the
query’s established error-status check, preserving direct option handling for
non-error states, and add coverage for a falsy rejected value.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 9e770acb-1a84-48ad-bfad-7ea1ea56d651
📒 Files selected for processing (5)
.changeset/preact-retry-on-mount-throw-on-error.mdpackages/preact-query/src/__tests__/useQuery.test.tsxpackages/preact-query/src/errorBoundaryUtils.tspackages/preact-query/src/useBaseQuery.tspackages/preact-query/src/useQueries.ts
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
View your CI Pipeline Execution ↗ for commit e060a89
☁️ Nx Cloud last updated this comment at |
2 participants
🎯 Changes
Fixes #11165.
Ports #9338 to
preact-query. react-query'sensurePreventErrorBoundaryRetryevaluates a function-formthrowOnErroragainst the query's actual error before disablingretryOnMount; preact-query's copy still treats any function as truthy, sothrowOnError: () => false(or a predicate returningfalsefor the current error) wrongly prevents an errored query from refetching on remount.errorBoundaryUtils.ts: accept the cached query and evaluate function-formthrowOnErrorviashouldThrowError, same as react-query.useBaseQuery.ts: look the query up once byqueryHashand reuse it forensurePreventErrorBoundaryRetry,getHasError, and theexperimental_prefetchInRenderpromise (mirrors the react-query shape after fix(react-query): allow retryOnMount when throwOnError is function (#9336) #9338).useQueries.ts: pass the cached query per defaulted options.mainand pass with this change.✅ Checklist
pnpm run test:pr.🚀 Release Impact
🤖 Generated with Claude Code
Summary by CodeRabbit
throwOnErroris configured as a function.