Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 7a1fe3d
☁️ Nx Cloud last updated this comment at |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
@tanstack/angular-store
@tanstack/lit-store
@tanstack/octane-store
@tanstack/preact-store
@tanstack/react-store
@tanstack/solid-store
@tanstack/store
@tanstack/svelte-store
@tanstack/vue-store
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
The existing derived benchmark combines graph construction, subscription, and an update, making reactive graph regressions hard to isolate. Add 24 core benchmarks covering basic operations, fan-out, observed and unobserved graphs, equality fast paths, subscription lifecycle, dynamic dependencies, batching, and field selections.
Fixtures, verification, and cleanup stay outside timing. Unobserved dependency reads and writes are measured separately; lifecycle checks verify notifications before a read can repair missing connections. The application workload measures 200 single-field updates across 100 selections in every invocation, with untimed checks of each notification's field, value, and update index. This exercises the whole sequence even when CodSpeed measures only one invocation.
Add a dedicated Node benchmark config with coverage/typechecking disabled and a pinned CodSpeed simulation workflow for PRs,
main, and manual dispatch. Framework comparisons remain outside this suite. Pin@codspeed/vitest-pluginto6.0.0-beta.2for Node 24/Vite 8 compatibility; document baseline collection before enabling regression thresholds.Validation
pnpm test:pr --base=upstream/mainpasses all 108 tasks. The initial sandboxed run crashed in five Angular example builds; those builds passed outside the sandbox on Node 24, with the other 103 tasks served from the successful local cache.✅ Checklist
pnpm test:pr.🚀 Release Impact