Fix nested TypeDoc index routes - #1160
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughDocs path resolution now separates render paths from canonical lookup paths. Manifest normalization and matching handle terminal ChangesDocumentation route canonicalization
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This localized route-resolution change preserves nested TypeDoc pages and adds targeted coverage; no actionable merge-blocking risk remains beyond normal checks and review. Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | eb43c81 | Commit Preview URL Branch Preview URL |
Aug 14 2026, 08:09 PM |
What changed
index/indexfiles distinct from their parent package indexWhy
The docs manifest already removes one trailing
/index. The route resolver removed another one while normalizing manifest entries, which collapsed valid nested TypeDoc pages. Core links redirected to/reference, framework links could redirect back to the core reference, and subsequent relative navigation could end in a 404.Impact
Generated TypeDoc links such as
/table/latest/docs/reference/index/indexand/table/latest/docs/framework/react/reference/index/indexnow render their intended documents without cross-framework redirects.Validation
pnpm testDebugOptionsroutesSummary by CodeRabbit
Bug Fixes
/index.Tests