You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix: make logo asset menus accessible by keyboard - #1395
Logo asset menus now have a named keyboard entry point in the navbar and sign-in screens. The button appears when focused, and logo links keep their normal navigation behavior.
AI review notes:
Replaces the empty dropdown trigger with Radix Menu's virtual anchor, reusing the menu dependency already installed through Dropdown. Only the outer navbar/login/OAuth wrappers expose a button, so nested logo wrappers do not add duplicate tab stops or buttons inside links.
Agent-run isolated browser checks covered Tab, Enter, Space, Shift+F10, the ContextMenu key, arrow navigation, Escape focus restoration, normal link activation, and right-click with nested wrappers. The fixture used the real component and generated Tailwind styles, with navigation, toast and clipboard services stubbed. This is not a full application or production verification. pnpm test passed: TypeScript, lint, 552 unit tests (4 skipped), 2,269 chat tests, and 20 desktop tests (1 skipped). Isolated minified component gzip increased by 475 bytes, which is not a production bundle measurement. The lockfile adds only a direct reference to the already installed Radix Menu version.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 3eb5177f-be35-44c1-88e9-faf1b8f906cf
📥 Commits
Reviewing files that changed from the base of the PR and between 9ab080e and a2c64a0.
⛔ Files ignored due to path filters: 1
pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing: 5
package.json
src/components/BrandContextMenu.tsx
src/components/Navbar.tsx
src/routes/login.tsx
src/routes/oauth/authorize.tsx
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
📝 Walkthrough
BrandContextMenu now uses Radix Menu for logo actions and supports pointer, keyboard, and optional button activation. Navbar, login, and OAuth authorization enable the button trigger.
Changes: Logo menu
Layer / File(s)
Summary
Radix menu behavior package.json, src/components/BrandContextMenu.tsx
Adds @radix-ui/react-menu and replaces the custom dropdown with Radix Menu. Right-click and keyboard events open the menu at the target position. An optional “Logo assets” button opens it below itself. Logo choices and navigation remain available as menu items.
Enable the logo trigger src/components/Navbar.tsx, src/routes/login.tsx, src/routes/oauth/authorize.tsx
These three locations pass showTrigger to BrandContextMenu.
sequenceDiagram
actor User
participant BrandContextMenu
participant RadixMenu as Radix Menu
User->>BrandContextMenu: Right-click or use ContextMenu / Shift+F10
BrandContextMenu->>RadixMenu: Open at the event target position
RadixMenu-->>User: Show logo choices and navigation item
Loading
Suggested reviewers:abeuty
Merge Risk:⚪ Minimal · up to a2c64
The keyboard-accessible logo menu appears ready to merge after normal checks; no actionable blocker is established.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 4 files. (1 skipped: 1 …
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: adding keyboard accessibility to the logo asset menus.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 4 files. (1 skipped: 1 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
Commit to this branch
Create a new PR
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logo asset menus now have a named keyboard entry point in the navbar and sign-in screens. The button appears when focused, and logo links keep their normal navigation behavior.
Related to #775.
Summary by CodeRabbit