🧹 [code health improvement] Refactor register_graphics to use extracted functions - #104
Conversation
Extracted inline closures inside `register_graphics` into private Rust module-level functions (`create_canvas`, `draw_rect`, `draw_circle`, `draw_line`, `save_png`, `save_jpeg`). Also introduced a shared `save_image_with_format` helper to eliminate duplicate file saving and error handling code. Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Extracted the inline closure callbacks inside the massive
register_graphicsmethod instdlib/src/graphics.rsinto standalone, module-private Rust functions (create_canvas,draw_rect,draw_circle,draw_line,save_png,save_jpeg). A shared helper function,save_image_with_format, was also created to DRY up thesave_pngandsave_jpegimplementations.💡 Why:
register_graphicswas excessively long and difficult to read due to housing multiple lengthy function implementations withinRc::new(StdFunction { ... })blocks. This refactoring greatly improves the maintainability and readability ofregister_graphicsand reduces code duplication in the image saving logic.✅ Verification: Verified the exact same logical behavior is preserved. Ran
cargo test -p techscript_stdlib test_graphics_canvas_drawingandcargo test --workspaceto ensure all tests passed and no regressions were introduced. Also rancargo fmt --all.✨ Result: A much cleaner, more concise
register_graphicsfunction, reduced code duplication for image formatting, and overall improved code health in thegraphics.rsfile.PR created automatically by Jules for task 9581920255701488411 started by @Tcode-Motion