🔒 Fix capability bypass in web standard library - #106
Conversation
This commit adds a missing context capability check for `Capability::Network` to the `start`, `serve`, and `fetch` functions in `stdlib/src/web.rs`. It also updates the module registration to require the network capability, preventing a potential capability bypass. Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This commit adds a missing context capability check for `Capability::Network` to the `start`, `serve`, and `fetch` functions in `stdlib/src/web.rs`. It also updates the module registration to require the network capability, preventing a potential capability bypass. Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
🎯 What: The
⚠️ Risk: If left unfixed, malicious or sandboxed TechScript code could start an HTTP server or perform HTTP requests even when the network capability is explicitly denied, leading to potential unauthorized network access or SSRF.
start,serve, andfetchfunctions instdlib/src/web.rsdid not verify if the execution context had theCapability::Networkpermission before initiating network operations, bypassing the runtime's security policy mechanism.🛡️ Solution: Added
ctx.config.capabilities.contains(&Capability::Network)checks at the beginning of the respective function callbacks, returning a standardRuntimeErroron failure (mirroring the approach inhttp.rs). Updatedregister_webto listCapability::Networkas a required capability.PR created automatically by Jules for task 15282649607834322092 started by @Tcode-Motion