Skip to content

🔒 Fix missing capability checks in std.socket network operations #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tcode-Motion wants to merge 3 commits into from
Closed

🔒 Fix missing capability checks in std.socket network operations #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ab11fa
Enforce Network capability checks for std.socket operations
google-labs-jules[bot] Sep 8, 2026
9762a94
Enforce Network capability checks for std.socket operations
google-labs-jules[bot] Sep 8, 2026
c97b33b
Merge branch 'main' into fix-socket-capability-check-9655494105280129390
Tcode-Motion Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 28 additions & 4 deletions stdlib/src/socket.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ use crate::{StdFunction, StdlibModule, StdlibRegistry};
use std::collections::HashMap;
use std::net::TcpStream;
use std::rc::Rc;
use techscript_runtime::{error::RuntimeError, value::RuntimeValue};
use techscript_runtime::{context::Capability, error::RuntimeError, value::RuntimeValue};

impl StdlibRegistry {
pub fn register_socket(&mut self) {
Expand All @@ -14,7 +14,7 @@ impl StdlibRegistry {
Rc::new(StdFunction {
name: "connect".to_string(),
arity: 2,
callback: |_ctx, args| {
callback: |ctx, args| {
let host = match &args[0] {
RuntimeValue::Str(s) => s.clone(),
_ => {
Expand Down Expand Up @@ -42,6 +42,18 @@ impl StdlibRegistry {
}
};
let addr = format!("{}:{}", host, port);

if !ctx.config.capabilities.contains(&Capability::Network) {
return Err(RuntimeError::new(
techscript_runtime::error::RuntimeErrorKind::InvalidOperation(
"Security policy violation: Network capability is denied"
.to_string(),
),
None,
None,
));
}

TcpStream::connect(&addr).map_err(|e| {
RuntimeError::new(
techscript_runtime::error::RuntimeErrorKind::InvalidOperation(
Expand All @@ -61,7 +73,7 @@ impl StdlibRegistry {
Rc::new(StdFunction {
name: "listen".to_string(),
arity: 1,
callback: |_ctx, args| {
callback: |ctx, args| {
let port = match &args[0] {
RuntimeValue::Int(n) => *n as u16,
_ => {
Expand All @@ -76,6 +88,18 @@ impl StdlibRegistry {
}
};
let addr = format!("0.0.0.0:{}", port);

if !ctx.config.capabilities.contains(&Capability::Network) {
return Err(RuntimeError::new(
techscript_runtime::error::RuntimeErrorKind::InvalidOperation(
"Security policy violation: Network capability is denied"
.to_string(),
),
None,
None,
));
}

let _listener = std::net::TcpListener::bind(&addr).map_err(|e| {
RuntimeError::new(
techscript_runtime::error::RuntimeErrorKind::InvalidOperation(
Expand All @@ -96,7 +120,7 @@ impl StdlibRegistry {
name: "std.socket".to_string(),
version: "1.0.0".to_string(),
exports,
required_capabilities: Vec::new(),
required_capabilities: vec![Capability::Network],
},
);
}
Expand Down
4 changes: 1 addition & 3 deletions stdlib/tests/stdlib_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1251,7 +1251,5 @@ fn test_ai_generate_text() {
let val = res.unwrap();
assert!(val.as_string().unwrap().contains("Prompt: What is 2+2?"));
}

#[test]
<<
}
<
Loading