Skip to content

🧹 [Refactor excessively long function resolve_statement in resolve.rs] - #114

Merged
Tcode-Motion merged 1 commit into
mainfrom
refactor-resolve-statement-13893757812891092637
Sep 8, 2026
Merged

🧹 [Refactor excessively long function resolve_statement in resolve.rs]#114
Tcode-Motion merged 1 commit into
mainfrom
refactor-resolve-statement-13893757812891092637

Conversation

@Tcode-Motion

Copy link
Copy Markdown
Owner

🎯 What: Extracted parsing logic for If, For, Try, and Import statements out of the excessively long monolithic resolve_statement method in compiler/semantic/src/passes/resolve.rs into smaller, dedicated helper methods (resolve_if, resolve_for, resolve_try, resolve_import).

💡 Why: resolve_statement was a massive, unmaintainable method that handled almost every statement variant inline. Breaking these specific branches into smaller pieces drastically reduces the cognitive load, decreases file clutter within that specific match scope, and makes it significantly easier to test or change statement resolving logic in the future.

Verification: Recompiled successfully with cargo check -p techscript_semantic, verified that logic remained structurally identical, and confirmed that the full workspace test suite passed without regression (cargo test --workspace).

Result: Improved modularity and readability of the semantic analysis module by converting a gigantic match block into much smaller delegated function calls, bringing resolve.rs significantly closer to healthy standard code practices.


PR created automatically by Jules for task 13893757812891092637 started by @Tcode-Motion

Extracted logic for `If`, `For`, `Try`, and `Import` statements into separate helper methods (`resolve_if`, `resolve_for`, `resolve_try`, and `resolve_import`) within `ResolveSymbols` to improve readability and maintainability.

Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@Tcode-Motion
Tcode-Motion marked this pull request as ready for review September 8, 2026 16:21
@Tcode-Motion
Tcode-Motion merged commit 3484aa2 into main Sep 8, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant