Skip to content

⚡ Optimize LSP boundary character lookups from O(N) to O(1) - #117

Merged
Tcode-Motion merged 2 commits into
mainfrom
jules-lsp-char-lookup-opt-10062600667242564767
Sep 8, 2026
Merged

⚡ Optimize LSP boundary character lookups from O(N) to O(1)#117
Tcode-Motion merged 2 commits into
mainfrom
jules-lsp-char-lookup-opt-10062600667242564767

Conversation

@Tcode-Motion

Copy link
Copy Markdown
Owner

💡 What: Replaced line.chars().nth() lookup calls in tools/lsp/src/lib.rs with line[..pos].chars().next_back() and line[pos..].chars().next().

🎯 Why: The original code used .chars().nth(byte_offset) inside a loop. This exhibited O(N^2) complexity on long lines because nth() traverses the string from the beginning in O(N) time for every match found. Additionally, because .find() returns a byte offset, passing it to nth() which expects a character index introduced a subtle bug when multi-byte unicode characters were present. The new approach uses the guaranteed-valid byte offset to slice the string and look at the immediately adjacent characters, running in O(1) time.

📊 Measured Improvement: A benchmark was added to verify the impact on a long line containing many matches. The time to execute the boundary checks dropped from ~1.7ms (slow) to ~45µs (fast).


PR created automatically by Jules for task 10062600667242564767 started by @Tcode-Motion

Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
@Tcode-Motion
Tcode-Motion marked this pull request as ready for review September 8, 2026 16:23
@Tcode-Motion
Tcode-Motion merged commit e35ac9b into main Sep 8, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant