Skip to content

🧹 [refactor] Break down excessively long build_dsl_registry function - #119

Merged
Tcode-Motion merged 1 commit into
mainfrom
code-health-refactor-dsl-registry-3064735118577765029
Sep 8, 2026
Merged

🧹 [refactor] Break down excessively long build_dsl_registry function#119
Tcode-Motion merged 1 commit into
mainfrom
code-health-refactor-dsl-registry-3064735118577765029

Conversation

@Tcode-Motion

Copy link
Copy Markdown
Owner

🎯 What: Extracted the schema insertion logic from the excessively long build_dsl_registry function into three domain-specific helper functions (register_web_schemas, register_canvas_schemas, and register_generic_schemas).
💡 Why: build_dsl_registry was nearly 500 lines long, making it hard to read and navigate. Breaking it down by logical module (Web, Canvas, Generic) greatly improves the maintainability and readability of dsl_schema.rs.
Verification: Ran cargo test -p techscript_semantic and cargo test --workspace successfully, ensuring the same schemas are built and functionality is preserved without side effects.
Result: A more modular and organized build_dsl_registry that is easier to maintain and extend in the future.


PR created automatically by Jules for task 3064735118577765029 started by @Tcode-Motion

…nction

Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@Tcode-Motion
Tcode-Motion marked this pull request as ready for review September 8, 2026 16:23
@Tcode-Motion
Tcode-Motion merged commit d292967 into main Sep 8, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant