Skip to content

🧹 [code health improvement] Refactor dsl_to_html in web.rs - #122

Merged
Tcode-Motion merged 1 commit into
mainfrom
code-health-refactor-web-294185737966890269
Sep 8, 2026
Merged

🧹 [code health improvement] Refactor dsl_to_html in web.rs#122
Tcode-Motion merged 1 commit into
mainfrom
code-health-refactor-web-294185737966890269

Conversation

@Tcode-Motion

Copy link
Copy Markdown
Owner

🎯 What: The code health issue addressed was the excessively long and complex dsl_to_html function in stdlib/src/web.rs. It consisted of a massive inline match block spanning hundreds of lines.
💡 Why: Breaking down the massive match block into dedicated helper functions like render_website and render_page drastically improves code maintainability. It reduces cyclomatic complexity, isolates logic for rendering different DSL blocks, and eliminates duplicated block traversal logic via the new render_children function.
Verification: I validated the changes by compiling the workspace and successfully running all tests, specifically cargo test -p techscript_stdlib and cargo test --workspace. The behavior is preserved precisely as the components were simply lifted into helper functions.
Result: The dsl_to_html function is now clean, readable, and properly delegates specialized rendering logic to dedicated helper functions.


PR created automatically by Jules for task 294185737966890269 started by @Tcode-Motion

…logical blocks into smaller helper functions (`render_website`, `render_page`, `render_hero`, `render_section`, `render_card`, `render_children`) to improve maintainability and readability.

Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@Tcode-Motion
Tcode-Motion marked this pull request as ready for review September 8, 2026 16:26
@Tcode-Motion
Tcode-Motion merged commit 5dbaba3 into main Sep 8, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant