Skip to content

🧹 Refactor register_sync in stdlib/src/sync.rs #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tcode-Motion wants to merge 3 commits into from
Closed

🧹 Refactor register_sync in stdlib/src/sync.rs #329

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
147f421
Refactor register_sync in stdlib/src/sync.rs
google-labs-jules[bot] Oct 27, 2026
61ca298
Refactor register_sync in stdlib/src/sync.rs
google-labs-jules[bot] Oct 27, 2026
502aea3
Refactor register_sync in stdlib/src/sync.rs
google-labs-jules[bot] Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 56 additions & 41 deletions stdlib/src/sync.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use std::cell::RefCell;
use std::collections::HashMap;
use std::rc::Rc;
use std::sync::{Condvar, Mutex};
use techscript_runtime::{error::RuntimeError, value::RuntimeValue};
use techscript_runtime::{error::RuntimeError, value::RuntimeValue, RuntimeContext};

pub struct ScriptMutex {
locked: Mutex<bool>,
Expand Down Expand Up @@ -34,6 +34,58 @@ impl ScriptMutex {
}
}

fn make_mutex(
ctx: &mut RuntimeContext,
_args: Vec<RuntimeValue>,
) -> Result<RuntimeValue, RuntimeError> {
let mutex = ScriptMutex::new();
let handle_id = ctx.resources.borrow_mut().insert(mutex);
let mut map = IndexMap::new();
map.insert("_handle".to_string(), RuntimeValue::Int(handle_id as i64));
Ok(RuntimeValue::Map {
entries: Rc::new(RefCell::new(map)),
is_const: false,
})
}

fn mutex_lock(
ctx: &mut RuntimeContext,
args: Vec<RuntimeValue>,
) -> Result<RuntimeValue, RuntimeError> {
if let RuntimeValue::Map { entries, .. } = &args[0] {
let handle_id = entries
.borrow()
.get("_handle")
.cloned()
.unwrap_or(RuntimeValue::Null)
.try_into_int()? as u32;
let resources = ctx.resources.borrow();
if let Some(mutex) = resources.get::<ScriptMutex>(handle_id) {
mutex.lock();
}
}
Ok(RuntimeValue::Null)
}

fn mutex_unlock(
ctx: &mut RuntimeContext,
args: Vec<RuntimeValue>,
) -> Result<RuntimeValue, RuntimeError> {
if let RuntimeValue::Map { entries, .. } = &args[0] {
let handle_id = entries
.borrow()
.get("_handle")
.cloned()
.unwrap_or(RuntimeValue::Null)
.try_into_int()? as u32;
let resources = ctx.resources.borrow();
if let Some(mutex) = resources.get::<ScriptMutex>(handle_id) {
mutex.unlock();
}
}
Ok(RuntimeValue::Null)
}

impl StdlibRegistry {
pub fn register_sync(&mut self) {
let mut exports: HashMap<String, Rc<dyn techscript_runtime::function::Callable>> =
Expand All @@ -44,16 +96,7 @@ impl StdlibRegistry {
Rc::new(StdFunction {
name: "make_mutex".to_string(),
arity: 0,
callback: |ctx, _args| {
let mutex = ScriptMutex::new();
let handle_id = ctx.resources.borrow_mut().insert(mutex);
let mut map = IndexMap::new();
map.insert("_handle".to_string(), RuntimeValue::Int(handle_id as i64));
Ok(RuntimeValue::Map {
entries: Rc::new(RefCell::new(map)),
is_const: false,
})
},
callback: make_mutex,
}),
);

Expand All @@ -62,21 +105,7 @@ impl StdlibRegistry {
Rc::new(StdFunction {
name: "mutex_lock".to_string(),
arity: 1,
callback: |ctx, args| {
if let RuntimeValue::Map { entries, .. } = &args[0] {
let handle_id = entries
.borrow()
.get("_handle")
.cloned()
.unwrap_or(RuntimeValue::Null)
.try_into_int()? as u32;
let resources = ctx.resources.borrow();
if let Some(mutex) = resources.get::<ScriptMutex>(handle_id) {
mutex.lock();
}
}
Ok(RuntimeValue::Null)
},
callback: mutex_lock,
}),
);

Expand All @@ -85,21 +114,7 @@ impl StdlibRegistry {
Rc::new(StdFunction {
name: "mutex_unlock".to_string(),
arity: 1,
callback: |ctx, args| {
if let RuntimeValue::Map { entries, .. } = &args[0] {
let handle_id = entries
.borrow()
.get("_handle")
.cloned()
.unwrap_or(RuntimeValue::Null)
.try_into_int()? as u32;
let resources = ctx.resources.borrow();
if let Some(mutex) = resources.get::<ScriptMutex>(handle_id) {
mutex.unlock();
}
}
Ok(RuntimeValue::Null)
},
callback: mutex_unlock,
}),
);

Expand Down
Loading