Skip to content

🧹 Extract huge Inno Setup strings into template files - #33

Merged
Tcode-Motion merged 1 commit into
mainfrom
extract-inno-templates-11258952867716041347
Aug 25, 2026
Merged

🧹 Extract huge Inno Setup strings into template files#33
Tcode-Motion merged 1 commit into
mainfrom
extract-inno-templates-11258952867716041347

Conversation

@Tcode-Motion

Copy link
Copy Markdown
Owner

🎯 What: Extracted the massive string literals defining Inno Setup scripts inside tools/packager/src/main.rs into separate .iss.template files (offline_installer.iss.template and online_installer.iss.template), and updated the code to use include_str! and str::replace().
💡 Why: Drastically improves maintainability and readability by separating the installer script data from the Rust packaging logic. It eliminates the need to escape curly braces ({{ and }}) that was previously required when using the format! macro, making the templates much easier to read and edit.
Verification: Verified by compiling the packager (cargo check -p techscript_packager), running the linter (cargo clippy -p techscript_packager -- -D warnings), and running the full workspace test suite (cargo test --workspace) to ensure no regressions were introduced.
Result: A cleaner, much smaller main.rs in the packager tool, and proper distinct files for maintaining setup templates.


PR created automatically by Jules for task 11258952867716041347 started by @Tcode-Motion

Moves the massively large string literals inside `generate_offline_inno_script` and `generate_online_inno_script` in `tools/packager/src/main.rs` into `offline_installer.iss.template` and `online_installer.iss.template`. This improves readability and avoids curly brace escaping issues from `format!`.

Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@Tcode-Motion
Tcode-Motion marked this pull request as ready for review August 25, 2026 09:46
@Tcode-Motion
Tcode-Motion merged commit a3155f2 into main Aug 25, 2026
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant