Skip to content

🔒 fix(stdlib): enforce FileSystem capability checks in file.rs - #36

Merged
Tcode-Motion merged 1 commit into
mainfrom
security/fix-filesystem-capabilities-8953389804118506594
Aug 25, 2026
Merged

🔒 fix(stdlib): enforce FileSystem capability checks in file.rs#36
Tcode-Motion merged 1 commit into
mainfrom
security/fix-filesystem-capabilities-8953389804118506594

Conversation

@Tcode-Motion

Copy link
Copy Markdown
Owner

🎯 What: This PR fixes a security vulnerability in stdlib/src/file.rs where file operations (read, write, copy, remove, exists) were missing capability checks, unlike std.fs in sys.rs.
⚠️ Risk: Without these checks, untrusted or sandboxed scripts executed by the runtime could bypass file system restrictions using std.file.* functions, potentially leading to unauthorized reads, modifications, or deletions of arbitrary files accessible by the host process.
🛡️ Solution: Added a check for Capability::FileSystem at the beginning of each file operation callback. If the capability is not present in ctx.config.capabilities, a RuntimeError is returned. Additionally, updated the register_module metadata for "std.file" to explicitly require Capability::FileSystem.


PR created automatically by Jules for task 8953389804118506594 started by @Tcode-Motion

Added missing `Capability::FileSystem` checks to `read`, `write`, `copy`, `remove`, and `exists` functions in `stdlib/src/file.rs` to prevent sandboxed code from bypassing restrictions. Also added the capability requirement to the `std.file` module registration.

Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@Tcode-Motion
Tcode-Motion marked this pull request as ready for review August 25, 2026 09:48
@Tcode-Motion
Tcode-Motion merged commit c413ffb into main Aug 25, 2026
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant