🔒 fix(stdlib): enforce FileSystem capability checks in file.rs - #36
Conversation
Added missing `Capability::FileSystem` checks to `read`, `write`, `copy`, `remove`, and `exists` functions in `stdlib/src/file.rs` to prevent sandboxed code from bypassing restrictions. Also added the capability requirement to the `std.file` module registration. Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: This PR fixes a security vulnerability in
⚠️ Risk: Without these checks, untrusted or sandboxed scripts executed by the runtime could bypass file system restrictions using
stdlib/src/file.rswhere file operations (read,write,copy,remove,exists) were missing capability checks, unlikestd.fsinsys.rs.std.file.*functions, potentially leading to unauthorized reads, modifications, or deletions of arbitrary files accessible by the host process.🛡️ Solution: Added a check for
Capability::FileSystemat the beginning of each file operation callback. If the capability is not present inctx.config.capabilities, aRuntimeErroris returned. Additionally, updated theregister_modulemetadata for"std.file"to explicitly requireCapability::FileSystem.PR created automatically by Jules for task 8953389804118506594 started by @Tcode-Motion