🔒 Fix path traversal vulnerability in unzip_archive - #45
Conversation
Replaced vulnerable manual ZIP extraction logic with the `zip` crate's `extract` method, which contains built-in protections against path traversal (Zip Slip) attacks, absolute paths, and escaping symlinks. Also bumped the `zip` crate dependency to version `2.4.2` to ensure modern security standards and bug fixes. Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Fixed a path traversal (Zip Slip) security vulnerability in the
⚠️ Risk: The previous manual extraction loop could allow a maliciously crafted zip archive containing absolute paths,
std.compress.unzipstandard library function.../segments, or deceptive symlinks to overwrite arbitrary files outside the intended destination directory on the host system.🛡️ Solution: Replaced the vulnerable manual loop with
archive.extract(dest_dir)?, the secure built-in method provided by thezipcrate. This method automatically sanitizes paths and enforces destination confinement. Also bumped thezipdependency to2.4.2instdlib/Cargo.tomlto access modern security features.PR created automatically by Jules for task 14086132353302438207 started by @Tcode-Motion