🧹 Replace unsafe LLVM unreachable with explicit compiler error for Throw - #46
Conversation
…hrow terminator The LLVM backend was previously generating an `unreachable` LLVM instruction for the `Throw` IR terminator, as full exception handling is not yet implemented. This led to unsafe execution and undefined behavior if triggered. This change modifies `codegen.rs` to return a clear Rust `Err` during compile time if an exception construct is encountered, causing compilation to gracefully fail instead of producing a potentially dangerous and undefined binary. Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎯 What: Modified the
Throwterminator arm incodegen.rsto return a RustErrinstead of emittingLLVMBuildUnreachable.💡 Why: Emitting
unreachablein LLVM for valid code paths is a bad practice that leads to undefined behavior at runtime if the path is ever taken. Returning a compilation error fails gracefully and clearly communicates that the feature is unsupported, improving compiler maintainability and user safety.✅ Verification: Verified the fix by running
cargo check -p techscript_llvm_backendand the full test suite (cargo test --workspace), which passed without regressions.✨ Result: Unimplemented exception handling now reliably results in a safe compile-time error rather than unpredictable runtime crashes.
PR created automatically by Jules for task 7317866299840611937 started by @Tcode-Motion