Skip to content

⚡ Bolt: [performance improvement] Eliminate redundant file existence checks #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tcode-Motion wants to merge 1 commit into from
Closed

⚡ Bolt: [performance improvement] Eliminate redundant file existence checks #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions cli/src/project.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,12 +148,10 @@ impl ProjectBuildGraph {

// 1. Add all entry points to compilation list
for pkg in self.workspace.packages.values_mut() {
if pkg.entry_file.exists() {
if let Ok(source) = std::fs::read_to_string(&pkg.entry_file) {
let fid = source_mgr.add_file(pkg.entry_file.clone(), source.clone());
pkg.entry_file_id = Some(fid);
to_resolve.push((fid, pkg.entry_file.clone(), pkg.name.clone()));
}
if let Ok(source) = std::fs::read_to_string(&pkg.entry_file) {
let fid = source_mgr.add_file(pkg.entry_file.clone(), source.clone());
pkg.entry_file_id = Some(fid);
to_resolve.push((fid, pkg.entry_file.clone(), pkg.name.clone()));
}
}

Expand Down Expand Up @@ -269,12 +267,10 @@ impl ProjectBuildGraph {
}
}

if import_file.exists() {
if let Ok(source) = std::fs::read_to_string(&import_file) {
let dep_fid = source_mgr.add_file(import_file.clone(), source);
dep_fids.push(dep_fid);
to_resolve.push((dep_fid, import_file, pkg_name.clone()));
}
if let Ok(source) = std::fs::read_to_string(&import_file) {
let dep_fid = source_mgr.add_file(import_file.clone(), source);
dep_fids.push(dep_fid);
to_resolve.push((dep_fid, import_file, pkg_name.clone()));
}
}

Expand Down
Loading