🧪 Add test and limit for parse_json_value recursive depth - #53
🧪 Add test and limit for parse_json_value recursive depth#53Tcode-Motion wants to merge 1 commit into
Conversation
The function `parse_json_value` was recursive but unbounded. Parsing an extremely nested JSON payload could result in stack overflows. We've added a `depth` parameter with a maximum allowed depth of 128. If that depth is reached, an explicit RuntimeError (`JSON depth limit exceeded`) is returned. A new test case has been added to verify that deep structures no longer crash the process. Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎯 What: Added a recursion depth limit (128) to
parse_json_valueto prevent stack overflows caused by deeply nested JSON parsing. It now returnsResult<RuntimeValue, RuntimeError>.📊 Coverage: A new integration test creates a nested structure 200 levels deep and successfully asserts that it results in an explicit error instead of a crash.
✨ Result: Enhanced the reliability and stability of the standard library by addressing a potential denial of service vulnerability/crash point in the JSON module.
PR created automatically by Jules for task 578437541062150611 started by @Tcode-Motion