🧹 [code health] Remove unused lexer code allowance - #98
Conversation
The `LogosToken` enum in `compiler/lexer/src/lib.rs` is fully utilized by the Logos macro and exhaustively mapped to `TokenKind`. It does not require the `#[allow(dead_code)]` attribute, so this attribute has been removed. Removed the leftover blank line as well. Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Removed the unnecessary
#[allow(dead_code)]attribute from theLogosTokenenum incompiler/lexer/src/lib.rs.💡 Why: The enum variants are actively used (generated by logos-derive and mapped exhaustively in
Lexer::map_logos_token). Removing the dead code allowance cleans up the code and ensures that if variants are ever actually unused in the future, the compiler will catch it, improving maintainability.✅ Verification: Ran
RUSTFLAGS="-D warnings" cargo check --workspaceandcargo test --workspaceto confirm that removing the attribute did not introduce any compilation warnings or errors, and all tests pass.✨ Result: Improved code cleanliness and stricter compilation checks for the lexer crate.
PR created automatically by Jules for task 13170916467475915447 started by @Tcode-Motion