Skip to content

🧹 [code health] Remove unused lexer code allowance - #98

Merged
Tcode-Motion merged 1 commit into
mainfrom
jules-lexer-code-health-13170916467475915447
Sep 8, 2026
Merged

🧹 [code health] Remove unused lexer code allowance#98
Tcode-Motion merged 1 commit into
mainfrom
jules-lexer-code-health-13170916467475915447

Conversation

@Tcode-Motion

Copy link
Copy Markdown
Owner

🎯 What: Removed the unnecessary #[allow(dead_code)] attribute from the LogosToken enum in compiler/lexer/src/lib.rs.
💡 Why: The enum variants are actively used (generated by logos-derive and mapped exhaustively in Lexer::map_logos_token). Removing the dead code allowance cleans up the code and ensures that if variants are ever actually unused in the future, the compiler will catch it, improving maintainability.
Verification: Ran RUSTFLAGS="-D warnings" cargo check --workspace and cargo test --workspace to confirm that removing the attribute did not introduce any compilation warnings or errors, and all tests pass.
Result: Improved code cleanliness and stricter compilation checks for the lexer crate.


PR created automatically by Jules for task 13170916467475915447 started by @Tcode-Motion

The `LogosToken` enum in `compiler/lexer/src/lib.rs` is fully utilized by the Logos macro and exhaustively mapped to `TokenKind`. It does not require the `#[allow(dead_code)]` attribute, so this attribute has been removed. Removed the leftover blank line as well.

Co-authored-by: Tcode-Motion <188012755+Tcode-Motion@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@Tcode-Motion
Tcode-Motion marked this pull request as ready for review September 8, 2026 15:55
@Tcode-Motion
Tcode-Motion merged commit 4fdf020 into main Sep 8, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant