Repository navigation
feat(workspaces): enable personal conversation workspaces - #1046
Merged
Merged
Conversation
Robert0622
reviewed
Nov 18, 2026
Robert0622
left a comment
Collaborator
There was a problem hiding this comment.
本地 Docker 工作区写入、发布和下载通过。补充回归发现首次开工作区失败后无法绑定项目,已标在代码行。
| return | ||
| } | ||
| s.workspaceRunID = bound.Previous | ||
| if err := h.repo.SetAssistantSessionWorkspaceRun(s.ChatOwnerID, s.ChatSessionID, s.ProjectID, bound.Previous, false); err != nil { |
Collaborator
There was a problem hiding this comment.
[P2] 打开个人工作区失败时回滚本次新增的归属记录
首次打开个人工作区时,准备失败会取消 run 并恢复 WorkspaceRunID。新增的 ID 仍留在 OwnWorkspaceRunIDs。模拟工作区树接口返回 503 后,当前对话已经解绑,绑定项目的 PUT 仍返回 HTTP 409,前端也会改走新开对话。请在回滚时一并移除本次创建失败的归属记录。
Robert0622
previously approved these changes
Nov 18, 2026
Robert0622
left a comment
Collaborator
There was a problem hiding this comment.
复测通过。首次打开个人工作区失败后可以绑定项目,切换环境失败后可以在同一轮恢复并复用原工作区。所有者访问和 Docker 写入、发布、下载回归通过。另有一项旧用例仍期待项目对话自动检出仓库,在 main 同样失败。
Robert0622
approved these changes
Nov 18, 2026
Robert0622
left a comment
Collaborator
There was a problem hiding this comment.
复审 4f86af0。真实 Docker 中的个人工作区写入、发布和下载通过,打开失败回滚后仍可绑定项目。个人工作区权限、按主机提供 Git 凭证以及项目对话自动登记 GitHub PR 和 GitLab MR 的回归通过。旧的 runner 自动检出用例在当前 main 同样失败。最新提交的 CI 全绿。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Closes #167
Scope
Compatibility
复用现有工作区、会话绑定和快照字段。个人对话使用共享 Docker 或 native 沙箱。
Validation
go test通过internal/httpapi、internal/engine、internal/runner、internal/knowledge和internal/domain,并复测个人工作区权限与复用用例。internal/repo回归通过,跳过一项在main可复现的既有统计失败TestMySQLReadsObserveExternalChangesWithoutReload。npm --prefix chatbot test通过 388 项用例。前端构建、go vet、公开内容检查和凭据扫描均通过。Safety